From: Manoj Iyer <manoj.iyer@canonical.com>
To: platform-driver-x86-approval@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: luto@mit.edu
Subject: Re: [PATCH] thinkpad-acpi: Enable microphone mute LED
Date: Thu, 4 Aug 2011 16:53:47 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1108041621120.1894@lazy> (raw)
Can we please have an ACK on the following patch by Andy Lutomirski
submitted to this list on May 24, with this patch
echo "1" >
/sys/devices/platform/thinkpad_acpi/leds/tpacpi::micmute/brightness
echo "0" >
/sys/devices/platform/thinkpad_acpi/leds/tpacpi::micmute/brightness
turns on and off the mic mute LED. I tested this on a Lenovo X220-Tablet.
Signed-off-by: Andy Lutomirski <luto <at> mit.edu>
---
drivers/platform/x86/thinkpad_acpi.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 2797a97..40723a6 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -5074,8 +5074,10 @@ static const char * const
tpacpi_led_names[TPACPI_LED_NUMLEDS] = {
"tpacpi::unknown_led2",
"tpacpi::unknown_led3",
"tpacpi::thinkvantage",
+ "tpacpi::unknown_led4",
+ "tpacpi::micmute",
};
-#define TPACPI_SAFE_LEDS 0x1081U
+#define TPACPI_SAFE_LEDS 0x5081U
static inline bool tpacpi_is_led_restricted(const unsigned int led)
{
@@ -5297,7 +5299,7 @@ static const struct tpacpi_quirk led_useful_qtable[]
__initconst = {
{ /* Lenovo */
.vendor = PCI_VENDOR_ID_LENOVO,
.bios = TPACPI_MATCH_ANY, .ec = TPACPI_MATCH_ANY,
- .quirks = 0x1fffU,
+ .quirks = 0x5fffU,
},
{ /* IBM ThinkPads with no EC version string */
.vendor = PCI_VENDOR_ID_IBM,
--
--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================
reply other threads:[~2011-08-04 22:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1108041621120.1894@lazy \
--to=manoj.iyer@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=platform-driver-x86-approval@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®