mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Cc: julia@diku.dk, Gilles.Muller@lip6.fr, npalix.work@gmail.com,
	mmarek@suse.cz, rdunlap@xenotime.net, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, cocci@diku.dk
Subject: Re: [RESEND 3/3] coccicheck: add parallel execution
Date: Sun, 6 Nov 2011 19:20:26 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.02.1111061920060.1873@hadrien> (raw)
In-Reply-To: <1320545653-28249-4-git-send-email-Gregory.Dietsche@cuw.edu>

On Sat, 5 Nov 2011, Gregory.Dietsche@cuw.edu wrote:

> From: Greg Dietsche <Gregory.Dietsche@cuw.edu>
>
> For example to process 6 SmPL patches at the same time:
> 	make coccicheck PARALLEL=6
>
> Results are held in /tmp until the scripts finish. By doing this the
> script is able to collate the results from each SmPL patch instead of
> interleaving them in the output.
>
> Version 2: change pkill -P $$ to pkill -s 0
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> Acked-by: Nicolas Palix <npalix.work@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> scripts/coccicheck |   27 ++++++++++++++++++++++++++-
> 1 files changed, 26 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 1bb1a1b..c2a04c2 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -97,10 +97,35 @@ coccinelle () {
>
> }
>
> +parallel_cleanup () {
> +	pkill -s 0 > /dev/null
> +	rm /tmp/cocci_parallel_$$_* 2>/dev/null
> +	exit
> +}
> +
> +trap parallel_cleanup SIGINT
> +PARALLEL_ID=0
> +
> if [ "$COCCI" = "" ] ; then
>     for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> -	coccinelle $f
> +	if [ "$PARALLEL" -eq "$PARALLEL" 2>/dev/null ] ; then
> +		if [ "$ONLINE" = "0" ] ; then
> +			echo Processing: `basename $f`
> +		fi
> +		coccinelle $f>/tmp/cocci_parallel_$$_$PARALLEL_ID 2>&1 &
> +		PARALLEL_ID=$(($PARALLEL_ID + 1))
> +		while [ "`jobs -p | wc -l`" -ge "$PARALLEL" ] ; do
> +			sleep 3
> +		done
> +	else
> +		coccinelle $f
> +	fi
>     done
> +    wait
> +    if [ "$PARALLEL_ID" -ge "0" ] ; then
> +	cat /tmp/cocci_parallel_$$_*
> +	parallel_cleanup
> +    fi
> else
>     coccinelle $COCCI
> fi
> -- 
> 1.7.6.4
>
>

  reply	other threads:[~2011-11-06 18:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-06  2:14 [RESEND 0/3] coccinelle: " Gregory.Dietsche
2011-11-06  2:14 ` [RESEND 1/3] coccinelle.txt: add overview section Gregory.Dietsche
2011-11-06 18:18   ` Julia Lawall
2011-11-06  2:14 ` [RESEND 2/3] coccinelle.txt: add documentation of PARALLEL= flag Gregory.Dietsche
2011-11-06 18:19   ` Julia Lawall
2011-11-06  2:14 ` [RESEND 3/3] coccicheck: add parallel execution Gregory.Dietsche
2011-11-06 18:20   ` Julia Lawall [this message]
2011-12-11 20:48   ` Michal Marek
2012-01-12 17:20     ` Greg Dietsche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1111061920060.1873@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Gregory.Dietsche@cuw.edu \
    --cc=cocci@diku.dk \
    --cc=julia@diku.dk \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=npalix.work@gmail.com \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome