From: Julia Lawall <julia.lawall@lip6.fr>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] drivers/mtd/nand/txx9ndfmc.c: use devm_request_and_ioremap
Date: Tue, 27 Dec 2011 15:46:10 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1112271545480.1838@localhost6.localdomain6> (raw)
In-Reply-To: <1324997145.1165.88.camel@sauron.fi.intel.com>
On Tue, 27 Dec 2011, Artem Bityutskiy wrote:
> On Tue, 2011-12-27 at 15:01 +0100, Julia Lawall wrote:
>> From: Julia Lawall <julia@diku.dk>
>>
>> Reimplement a call to devm_request_mem_region followed by a call to ioremap
>> or ioremap_nocache by a call to devm_request_and_ioremap.
>>
>> The semantic patch that makes this transformation is as follows:
>> (http://coccinelle.lip6.fr/)
>>
>> // <smpl>
>> @nm@
>> expression myname;
>> identifier i;
>> @@
>>
>> struct platform_driver i = { .driver = { .name = myname } };
>>
>> @@
>> expression dev,res,size;
>> expression nm.myname;
>> @@
>>
>> -if (!devm_request_mem_region(dev, res->start, size,
>> - \(res->name\|dev_name(dev)\|myname\))) {
>> - ...
>> - return ...;
>> -}
>> ... when != res->start
>> (
>> -devm_ioremap(dev,res->start,size)
>> +devm_request_and_ioremap(dev,res)
>> |
>> -devm_ioremap_nocache(dev,res->start,size)
>> +devm_request_and_ioremap(dev,res)
>> )
>> ... when any
>> when != res->start
>> // </smpl>
>>
>> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> Pushed to l2-mtd-2.6.git, thanks!
>
> I think this semantic patch is also useful and deserves to be added to
> scripts/coccinelle. In general, it would be great if you sumbitted
> useful spatches there for inclusion.
OK, I will add this one as well.
julia
prev parent reply other threads:[~2011-12-27 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 14:01 [PATCH 0/6] " Julia Lawall
2011-12-27 14:01 ` [PATCH 1/6] drivers/gpio/gpio-tegra.c: " Julia Lawall
2012-01-02 8:44 ` Grant Likely
2011-12-27 14:01 ` [PATCH 3/6] drivers/watchdog/imx2_wdt.c: " Julia Lawall
2011-12-27 14:01 ` [PATCH 4/6] drivers/watchdog/dw_wdt.c: " Julia Lawall
2011-12-27 14:01 ` [PATCH 5/6] drivers/char/hw_random/tx4939-rng.c: " Julia Lawall
2012-01-13 5:36 ` Herbert Xu
2011-12-27 14:01 ` [PATCH 6/6] drivers/mtd/nand/txx9ndfmc.c: " Julia Lawall
2011-12-27 14:45 ` Artem Bityutskiy
2011-12-27 14:46 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1112271545480.1838@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®