From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932094Ab2BHMjc (ORCPT ); Wed, 8 Feb 2012 07:39:32 -0500 Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:33216 "EHLO mail4-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069Ab2BHMja (ORCPT ); Wed, 8 Feb 2012 07:39:30 -0500 X-IronPort-AV: E=Sophos;i="4.73,383,1325458800"; d="scan'208";a="130570940" Date: Wed, 8 Feb 2012 13:39:29 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Dong Aisheng cc: Mark Brown , Julia Lawall , "alsa-devel@alsa-project.org" , Takashi Iwai , "kernel-janitors@vger.kernel.org" , Wolfram Sang , "linux-kernel@vger.kernel.org" , Dong Aisheng-B29396 , Liam Girdwood Subject: Re: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap In-Reply-To: Message-ID: References: <1326362117-29371-1-git-send-email-Julia.Lawall@lip6.fr> <7FE21149F4667147B645348EC605788508FBDB@039-SN2MPN1-013.039d.mgd.msft.net> <20120124202203.GD1135@opensource.wolfsonmicro.com> <20120126110506.GB2611@pengutronix.de> <20120126112242.GA9401@opensource.wolfsonmicro.com> <20120206162017.GM3070@opensource.wolfsonmicro.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1673869226-1328704770=:1833" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1673869226-1328704770=:1833 Content-Type: TEXT/PLAIN; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 8 Feb 2012, Dong Aisheng wrote: > On Tue, Feb 7, 2012 at 12:20 AM, Mark Brown > wrote: >> On Sat, Jan 28, 2012 at 08:03:34AM +0100, Julia Lawall wrote: >> >>> patch against >>> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git >> >> Hrm, I know there had been some debate about what to generate against >> but this now once again fails to apply against for-3.4...  No idea >> what's going on there and I didn't investigate the conflicts, sorry. >> >> I had been waiting in the vauge hope that some of the mxs maintainers >> would review. >> > I also failed to apply it against for-3.4. > It seemed the conflicts are a lot. > > Hi Julia, > > Can you regenerate the patch based on Mark's for-3.4 branch? > > BTW, i wonder if this patch's title should be changed a bit > since what this patch does is not adding missing iounmap anymore. > Maybe like: ASoC: mxs-saif: convert to use devm_kmalloc and its friends. Yes, thanks for the suggestions. I will do both shortly (today or tomorrow). julia --8323328-1673869226-1328704770=:1833--