From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: almost time to run my kernel source cleaning scripts again?
Date: Wed, 11 Apr 2012 20:46:38 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1204112046080.3300@oneiric> (raw)
In-Reply-To: <4F860905.4090106@gmail.com>
On Wed, 11 Apr 2012, David Daney wrote:
> On 04/11/2012 02:07 PM, Robert P. J. Day wrote:
> >
> > it's been a while so i was thinking of firing up my scripts to
> > peruse the source tree looking for oddities/inconsistencies/whatever
> > (unless someone else is already doing that).
> >
> > one example is looking for preprocessor tests of symbols that aren't
> > defined in any Kconfig file, and i can focus on any part of the source
> > tree. for example, if i run that script against drivers/mmc, i get:
> [...]
> >
> > > > > > > CAVIUM_OCTEON_NUM_PACKET_BUFFERS
> > drivers/staging/octeon/ethernet-defines.h:36: *
> > CONFIG_CAVIUM_OCTEON_NUM_PACKET_BUFFERS
> > drivers/staging/octeon/ethernet.c:56:#if
> > defined(CONFIG_CAVIUM_OCTEON_NUM_PACKET_BUFFERS) \
> > drivers/staging/octeon/ethernet.c:57: &&
> > CONFIG_CAVIUM_OCTEON_NUM_PACKET_BUFFERS
> > drivers/staging/octeon/ethernet.c:58:int num_packet_buffers =
> > CONFIG_CAVIUM_OCTEON_NUM_PACKET_BUFFERS;
>
> I am aware of these and am working on fixing them.
sorry, i wasn't trying to pick on anyone, it was just a random
example.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
prev parent reply other threads:[~2012-04-12 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 21:07 Robert P. J. Day
2012-04-11 21:52 ` Jesper Juhl
2012-04-11 22:12 ` Robert P. J. Day
2012-04-11 22:43 ` David Daney
2012-04-12 0:46 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1204112046080.3300@oneiric \
--to=rpjday@crashcourse.ca \
--cc=ddaney.cavm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®