From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Documentation/CodingStyle: Explain using GCC's statement expression extension for defining macros
Date: Sat, 14 Jul 2012 06:32:40 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1207140628490.20460@oneiric> (raw)
Add an explanation of how to use GCC's statement expression extension
for defining multi-line macros.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index cb9258b..c0eec33 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -600,7 +600,9 @@ may be named in lower case.
Generally, inline functions are preferable to macros resembling functions.
-Macros with multiple statements should be enclosed in a do - while block:
+Macros with multiple statements can be defined in one of two ways. The
+original technique encloses the body of the macro in a do - while block,
+as in:
#define macrofun(a, b, c) \
do { \
@@ -608,6 +610,17 @@ Macros with multiple statements should be enclosed in a do - while block:
do_this(b, c); \
} while (0)
+An alternative technique is to use GCC's statement expression extension,
+explained at http://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html,
+which allows you to place statements and declarations in a single expression,
+as with this example from <linux/kernel.h>:
+
+#define roundup(x, y) \
+({ \
+ const typeof(y) __y = y; \
+ (((x) + (__y - 1)) / __y) * __y; \
+})
+
Things to avoid when using macros:
1) macros that affect control flow:
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
reply other threads:[~2012-07-14 10:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1207140628490.20460@oneiric \
--to=rpjday@crashcourse.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®