From: Manoj Iyer <manoj.iyer@canonical.com>
To: manoj.iyer@canonical.com
Cc: linux-kernel@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org, mjg@redhat.com,
ibm-acpi@hmh.eng.br
Subject: Re: [PATCH] thinkpad-acpi: recognize latest V-Series using DMI_BIOS_VENDOR
Date: Fri, 3 Aug 2012 00:07:06 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1208030005470.3041@lazy> (raw)
In-Reply-To: <1343968187-20930-1-git-send-email-manoj.iyer@canonical.com>
Oops! This is embarrassing! my logic is flawed. Please ignore this patch,
I will resend it
NACK
On Thu, 2 Aug 2012, manoj.iyer@canonical.com wrote:
> From: Manoj Iyer <manoj.iyer@canonical.com>
>
> In the latest V-series bios DMI_PRODUCT_VERSION does not contain
> the string Lenovo or Thinkpad, but is set to the model number, this
> causes the thinkpad_acpi module to fail to load. Recognize laptop
> as Lenovo using DMI_BIOS_VENDOR instead, which is set to Lenovo.
>
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index e7f7328..eec0b65 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8657,7 +8657,8 @@ static int __must_check __init get_thinkpad_model_data(
> }
> }
>
> - s = dmi_get_system_info(DMI_PRODUCT_VERSION);
> + s = dmi_get_system_info(DMI_PRODUCT_VERSION) ?
> + dmi_get_system_info(DMI_BIOS_VENDOR) : NULL;
> if (s && !(strnicmp(s, "ThinkPad", 8) && strnicmp(s, "Lenovo", 6))) {
> tp->model_str = kstrdup(s, GFP_KERNEL);
> if (!tp->model_str)
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================
next prev parent reply other threads:[~2012-08-03 5:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 4:29 manoj.iyer
2012-08-03 5:07 ` Manoj Iyer [this message]
2012-08-04 1:39 ` Henrique de Moraes Holschuh
-- strict thread matches above, loose matches on Subject: below --
2012-08-06 23:15 manoj.iyer
2012-08-06 22:21 manoj.iyer
2012-08-06 21:23 manoj.iyer
2012-08-03 4:29 manoj.iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1208030005470.3041@lazy \
--to=manoj.iyer@canonical.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®