From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753204Ab2HOJUi (ORCPT ); Wed, 15 Aug 2012 05:20:38 -0400 Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:44710 "EHLO mail4-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662Ab2HOJUh (ORCPT ); Wed, 15 Aug 2012 05:20:37 -0400 X-IronPort-AV: E=Sophos;i="4.77,772,1336341600"; d="scan'208";a="153113716" Date: Wed, 15 Aug 2012 11:20:34 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Lars-Peter Clausen cc: Jonathan Cameron , Julia Lawall , Jonathan Cameron , kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/iio/adc/at91_adc.c: use devm_ functions In-Reply-To: <502B658F.5040100@metafoo.de> Message-ID: References: <1343729383-30073-1-git-send-email-Julia.Lawall@lip6.fr> <5017D148.6030006@metafoo.de> <502AB5F1.3050908@kernel.org> <502B658F.5040100@metafoo.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > devm_request_and_ioremap will already print a error messages on it's own if > something goes wrong. So strictly speaking this one is redundant, but I don't > think it is necessary to do a resend just for this, maybe you can remove the > extra dev_err when you apply the patch. Thanks for pointing that out. I will get rid of the messages in the future. That seems easier than figuring out how to adapt the message to the new function. julia