From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756142Ab2INQHg (ORCPT ); Fri, 14 Sep 2012 12:07:36 -0400 Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:56970 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726Ab2INQHe (ORCPT ); Fri, 14 Sep 2012 12:07:34 -0400 X-IronPort-AV: E=Sophos;i="4.80,423,1344211200"; d="scan'208";a="14551471" Date: Fri, 14 Sep 2012 17:06:16 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Konrad Rzeszutek Wilk CC: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xensource.com" , Stefano Stabellini Subject: Re: [PATCH 08/10] xen/swiotlb: Remove functions not needed anymore. In-Reply-To: <1347306367-28669-9-git-send-email-konrad.wilk@oracle.com> Message-ID: References: <1347306367-28669-1-git-send-email-konrad.wilk@oracle.com> <1347306367-28669-9-git-send-email-konrad.wilk@oracle.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Sep 2012, Konrad Rzeszutek Wilk wrote: > Sparse warns us off: > drivers/xen/swiotlb-xen.c:506:1: warning: symbol 'xen_swiotlb_map_sg' was not declared. Should it be static? > drivers/xen/swiotlb-xen.c:534:1: warning: symbol 'xen_swiotlb_unmap_sg' was not declared. Should it be static? > > and it looks like we do not need this function at all. A grep seems to find them used in arch/x86/xen/pci-swiotlb-xen.c. I fail to see where you removed them from pci-swiotlb-xen.c. Is it in this patch series or another one? > Signed-off-by: Konrad Rzeszutek Wilk > --- > drivers/xen/swiotlb-xen.c | 16 ---------------- > include/xen/swiotlb-xen.h | 9 --------- > 2 files changed, 0 insertions(+), 25 deletions(-) > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > index f0825cb..6f81994 100644 > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -514,14 +514,6 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > } > EXPORT_SYMBOL_GPL(xen_swiotlb_map_sg_attrs); > > -int > -xen_swiotlb_map_sg(struct device *hwdev, struct scatterlist *sgl, int nelems, > - enum dma_data_direction dir) > -{ > - return xen_swiotlb_map_sg_attrs(hwdev, sgl, nelems, dir, NULL); > -} > -EXPORT_SYMBOL_GPL(xen_swiotlb_map_sg); > - > /* > * Unmap a set of streaming mode DMA translations. Again, cpu read rules > * concerning calls here are the same as for swiotlb_unmap_page() above. > @@ -542,14 +534,6 @@ xen_swiotlb_unmap_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > } > EXPORT_SYMBOL_GPL(xen_swiotlb_unmap_sg_attrs); > > -void > -xen_swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sgl, int nelems, > - enum dma_data_direction dir) > -{ > - return xen_swiotlb_unmap_sg_attrs(hwdev, sgl, nelems, dir, NULL); > -} > -EXPORT_SYMBOL_GPL(xen_swiotlb_unmap_sg); > - > /* > * Make physical memory consistent for a set of streaming mode DMA translations > * after a transfer. > diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h > index f26f9f3..a0db2b7 100644 > --- a/include/xen/swiotlb-xen.h > +++ b/include/xen/swiotlb-xen.h > @@ -23,15 +23,6 @@ extern dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page, > extern void xen_swiotlb_unmap_page(struct device *hwdev, dma_addr_t dev_addr, > size_t size, enum dma_data_direction dir, > struct dma_attrs *attrs); > -/* > -extern int > -xen_swiotlb_map_sg(struct device *hwdev, struct scatterlist *sg, int nents, > - enum dma_data_direction dir); > - > -extern void > -xen_swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sg, int nents, > - enum dma_data_direction dir); > -*/ > extern int > xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > int nelems, enum dma_data_direction dir, > -- > 1.7.7.6 >