From: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH] xen/xen_initial_domain: check that xen_start_info is initialized
Date: Wed, 3 Oct 2012 18:08:52 +0100 [thread overview]
Message-ID: <alpine.DEB.2.02.1210031807340.29232@kaball.uk.xensource.com> (raw)
In-Reply-To: <1349282492.650.185.camel@zakaz.uk.xensource.com>
Since commit commit 4c071ee5268f7234c3d084b6093bebccc28cdcba ("arm:
initial Xen support") PV on HVM guests can be xen_initial_domain.
However PV on HVM guests might have an unitialized xen_start_info, so
check before accessing its fields.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
diff --git a/include/xen/xen.h b/include/xen/xen.h
index 9a39ca5..e7101bb 100644
--- a/include/xen/xen.h
+++ b/include/xen/xen.h
@@ -28,7 +28,7 @@ extern enum xen_domain_type xen_domain_type;
#include <asm/xen/hypervisor.h>
#define xen_initial_domain() (xen_domain() && \
- xen_start_info->flags & SIF_INITDOMAIN)
+ xen_start_info && xen_start_info->flags & SIF_INITDOMAIN)
#else /* !CONFIG_XEN_DOM0 */
#define xen_initial_domain() (0)
#endif /* CONFIG_XEN_DOM0 */
next prev parent reply other threads:[~2012-10-03 17:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 13:37 [PATCH] xen: point xen_start_info to a dummy struct for PV on HVM guests Stefano Stabellini
2012-10-03 13:43 ` Konrad Rzeszutek Wilk
2012-10-03 15:48 ` Stefano Stabellini
2012-10-03 13:49 ` [Xen-devel] " Ian Campbell
2012-10-03 13:51 ` Stefano Stabellini
2012-10-03 13:54 ` Ian Campbell
2012-10-03 14:11 ` Konrad Rzeszutek Wilk
2012-10-03 15:00 ` Ian Campbell
2012-10-03 15:48 ` Stefano Stabellini
2012-10-03 15:57 ` Ian Campbell
2012-10-03 16:05 ` Stefano Stabellini
2012-10-03 16:13 ` Ian Campbell
2012-10-03 16:41 ` Ian Campbell
2012-10-03 17:06 ` Stefano Stabellini
2012-10-03 17:08 ` Stefano Stabellini [this message]
2012-10-04 7:43 ` [Xen-devel] [PATCH] xen/xen_initial_domain: check that xen_start_info is initialized Jan Beulich
2012-10-04 10:07 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1210031807340.29232@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®