From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"mukesh.rathor@oracle.com" <mukesh.rathor@oracle.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 5/6] xen/pvh: balloon and grant changes.
Date: Mon, 22 Oct 2012 17:40:19 +0100 [thread overview]
Message-ID: <alpine.DEB.2.02.1210221738440.2689@kaball.uk.xensource.com> (raw)
In-Reply-To: <20121022160455.GC25200@phenom.dumpdata.com>
On Mon, 22 Oct 2012, Konrad Rzeszutek Wilk wrote:
> > > +
> > > int ret;
> > > ret = HYPERVISOR_update_va_mapping(
> > > (unsigned long)__va(pfn << PAGE_SHIFT),
> > > @@ -418,12 +420,13 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
> > > scrub_page(page);
> > >
> > > if (xen_pv_domain() && !PageHighMem(page)) {
> > > - ret = HYPERVISOR_update_va_mapping(
> > > - (unsigned long)__va(pfn << PAGE_SHIFT),
> > > - __pte_ma(0), 0);
> > > - BUG_ON(ret);
> > > + if (!xen_feature(XENFEAT_auto_translated_physmap)) {
> > > + ret = HYPERVISOR_update_va_mapping(
> > > + (unsigned long)__va(pfn << PAGE_SHIFT),
> > > + __pte_ma(0), 0);
> > > + BUG_ON(ret);
> > > + }
> > > }
> >
> > this change, unlike the one before, actually makes things different for
> > traditional pv domains in case PageHighMem(page).
>
> How? He is not altering the !PageHighMem check. Just adding a check
> before the hypercall to render it nop on PVH.
sorry, you are right, I need new glasses
next prev parent reply other threads:[~2012-10-22 16:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 1:17 Konrad Rzeszutek Wilk
2012-10-20 1:17 ` [PATCH 1/6] xen/pvh: Support ParaVirtualized Hardware extensions Konrad Rzeszutek Wilk
2012-10-22 13:38 ` Stefano Stabellini
2012-10-23 14:07 ` Konrad Rzeszutek Wilk
2012-10-24 9:29 ` Ian Campbell
2012-10-23 14:46 ` Konrad Rzeszutek Wilk
2012-10-24 9:27 ` Ian Campbell
2012-10-20 1:17 ` [PATCH 2/6] xen/pvh: Extend vcpu_guest_context, p2m, event, and xenbus to support PVH Konrad Rzeszutek Wilk
2012-10-22 13:44 ` Stefano Stabellini
2012-10-22 15:40 ` Konrad Rzeszutek Wilk
2012-10-22 18:31 ` Mukesh Rathor
2012-10-22 20:14 ` Konrad Rzeszutek Wilk
2012-10-22 20:39 ` Mukesh Rathor
2012-10-23 12:25 ` Stefano Stabellini
2012-10-20 1:17 ` [PATCH 3/6] xen/pvh: Implements mmu changes for PVH Konrad Rzeszutek Wilk
2012-10-22 13:46 ` Stefano Stabellini
2012-10-20 1:18 ` [PATCH 4/6] xen/pvh: bootup and setup related changes Konrad Rzeszutek Wilk
2012-10-22 13:34 ` Stefano Stabellini
2012-10-22 15:57 ` Konrad Rzeszutek Wilk
2012-10-23 13:07 ` Stefano Stabellini
2012-10-23 23:47 ` Mukesh Rathor
2012-10-24 0:03 ` [Xen-devel] " Mukesh Rathor
2012-10-24 0:10 ` Mukesh Rathor
2012-10-25 12:38 ` Konrad Rzeszutek Wilk
2012-10-20 1:18 ` [PATCH 5/6] xen/pvh: balloon and grant changes Konrad Rzeszutek Wilk
2012-10-22 13:25 ` Stefano Stabellini
2012-10-22 16:04 ` Konrad Rzeszutek Wilk
2012-10-22 16:40 ` Stefano Stabellini [this message]
2012-10-20 1:18 ` [PATCH 6/6] xen/pvh: /dev/xen/privcmd changes Konrad Rzeszutek Wilk
2012-10-22 13:22 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1210221738440.2689@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®