From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203Ab2LMKS4 (ORCPT ); Thu, 13 Dec 2012 05:18:56 -0500 Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:14420 "EHLO mail1-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753357Ab2LMKSz (ORCPT ); Thu, 13 Dec 2012 05:18:55 -0500 X-IronPort-AV: E=Sophos;i="4.84,273,1355094000"; d="scan'208";a="185956025" Date: Thu, 13 Dec 2012 11:18:53 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Dan Carpenter cc: Evgeniy Polyakov , Julia Lawall , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drivers/w1/masters/mxc_w1.c: use devm_ functions In-Reply-To: <20121213093938.GX6568@mwanda> Message-ID: References: <1354835724-26945-2-git-send-email-Julia.Lawall@lip6.fr> <20121211212555.GA15333@ioremap.net> <20121213093938.GX6568@mwanda> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Dec 2012, Dan Carpenter wrote: > On Wed, Dec 12, 2012 at 01:25:56AM +0400, Evgeniy Polyakov wrote: > > I suppose mdev will be automatically freed, but who will release > > mdev->clk and other private members of mdev structure? > > + mdev->clk = devm_clk_get(&pdev->dev, NULL); > > ->clk is now a devm pointer as well. Thanks for the suggestion. I will submit a patch shortly. julia