From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753010Ab3ACJk0 (ORCPT ); Thu, 3 Jan 2013 04:40:26 -0500 Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:7146 "EHLO mail4-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915Ab3ACJkX (ORCPT ); Thu, 3 Jan 2013 04:40:23 -0500 X-IronPort-AV: E=Sophos;i="4.84,402,1355094000"; d="scan'208";a="167327736" Date: Thu, 3 Jan 2013 10:40:20 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: lethal@linux-sh.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: clk dereference in arch/sh/kernel/cpufreq.c Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There has been a discussion recently about how the result of get_clk should be an opaque handle, not a value that can be dereferenced: https://lkml.org/lkml/2012/12/20/105 There is such a dereference in arch/sh/kernel/cpufreq.c, in the function sh_cpufreq_cpu_init: freq_table = cpuclk->nr_freqs ? cpuclk->freq_table : NULL; It was not obvious to me, however, what API function should be used instead, so I am just reporting the (potential) problem. thanks, julia