From: David Rientjes <rientjes@google.com>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 3/5] acpi: move x86/mm/srat.c to x86/kernel/acpi/srat.c
Date: Mon, 4 Feb 2013 11:44:34 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1302041142550.10378@chino.kir.corp.google.com> (raw)
In-Reply-To: <1359967426-32629-4-git-send-email-lig.fnst@cn.fujitsu.com>
On Mon, 4 Feb 2013, liguang wrote:
> srat table should present only on acpi domain,
> seems mm/ is not the right place for it.
>
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> arch/x86/kernel/acpi/Makefile | 1 +
> arch/x86/mm/Makefile | 1 -
> arch/x86/mm/srat.c | 191 -----------------------------------------
> 3 files changed, 1 insertions(+), 192 deletions(-)
> delete mode 100644 arch/x86/mm/srat.c
>
I was excited for a moment because this would have been one great cleanup,
but you never readded the code to arch/x86/kernel/acpi. (You probably
need to do "git add <newfile>" before generating the patch file.) I do
like the idea of moving it, though, if it's build tested thoroughly.
next prev parent reply other threads:[~2013-02-04 19:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 8:43 [PATCH 0/5] acpi: do some changes for numa info liguang
2013-02-04 8:43 ` [PATCH 1/5] numa: avoid export acpi_numa variable liguang
2013-02-04 19:31 ` David Rientjes
2013-02-05 0:56 ` li guang
2013-02-04 8:43 ` [PATCH 2/5] acpi/numa: check if parsing acpi numa info disabled earlier liguang
2013-02-04 19:41 ` David Rientjes
2013-02-05 1:12 ` li guang
2013-02-04 8:43 ` [PATCH 3/5] acpi: move x86/mm/srat.c to x86/kernel/acpi/srat.c liguang
2013-02-04 19:44 ` David Rientjes [this message]
2013-02-05 1:16 ` li guang
2013-02-04 8:43 ` [PATCH 4/5] acpi: add clock_domain field to acpi_srat_cpu_affinity liguang
2013-02-04 8:43 ` [PATCH 5/5] remove include asm/acpi.h in process_driver.c liguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1302041142550.10378@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®