From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751788Ab3BLUNa (ORCPT ); Tue, 12 Feb 2013 15:13:30 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:56664 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142Ab3BLUN1 (ORCPT ); Tue, 12 Feb 2013 15:13:27 -0500 Date: Tue, 12 Feb 2013 12:13:24 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Linus Torvalds cc: Steven Whitehouse , Christine Caulfield , David Teigland , cluster-devel@redhat.com, Linux Kernel Mailing List , Michal Marek Subject: Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled In-Reply-To: Message-ID: References: <1360662605.2719.13.camel@menhir> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Feb 2013, Linus Torvalds wrote: > On Tue, Feb 12, 2013 at 1:50 AM, Steven Whitehouse wrote: > > > > That doesn't seem right to me... DLM has not been experimental for a > > long time now. Why not just select CRC32 in addition to IP_SCTP ? > > Hmm. IP_SCTP already does a "select libcrc32c". So why doesn't that > end up working? > Kconfig won't select things that CONFIG_IP_SCTP select unless its "depends on" are satisfied, which is why I made CONFIG_DLM depend on CONFIG_EXPERIMENTAL. Steven says DLM hasn't been experimental for a long time; sorry, but if an option you select is experimental then you're experimental as well. If you'd like to push a patch that removes EXPERIMENTAL from IP_SCTP to David Miller, that works too. But that is a completely separate topic from dlm. For 3.8, I suggest respecting CONFIG_IP_SCTP's requirements and then removing EXPERIMENTAL from both if the networking guys agree.