From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758636Ab3B1XLA (ORCPT ); Thu, 28 Feb 2013 18:11:00 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:1079 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308Ab3B1XK5 (ORCPT ); Thu, 28 Feb 2013 18:10:57 -0500 X-IronPort-AV: E=Sophos;i="4.84,757,1355097600"; d="scan'208";a="9925613" Date: Thu, 28 Feb 2013 23:10:55 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Kees Cook CC: Stefano Stabellini , "linux-kernel@vger.kernel.org" , Konrad Rzeszutek Wilk , Jeremy Fitzhardinge , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , "xen-devel@lists.xensource.com" , "virtualization@lists.linux-foundation.org" , Mukesh Rathor Subject: Re: [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL In-Reply-To: Message-ID: References: <20130228215640.GA3136@www.outflux.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Feb 2013, Kees Cook wrote: > On Thu, Feb 28, 2013 at 2:53 PM, Stefano Stabellini > wrote: > > On Thu, 28 Feb 2013, Kees Cook wrote: > >> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a > >> while now and is almost always enabled by default. As agreed during the > >> Linux kernel summit, remove it from any "depends on" lines in Kconfigs. > >> > >> Signed-off-by: Kees Cook > >> Cc: Stefano Stabellini > >> Cc: Mukesh Rathor > >> Cc: Konrad Rzeszutek Wilk > >> --- > >> > >> v2: > >> - drop EXPERIMENTAL from bool and help text too. > >> > >> --- > >> arch/x86/xen/Kconfig | 8 +++----- > >> 1 file changed, 3 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > >> index 93ff4e1..6c5802f 100644 > >> --- a/arch/x86/xen/Kconfig > >> +++ b/arch/x86/xen/Kconfig > >> @@ -52,12 +52,10 @@ config XEN_DEBUG_FS > >> Enabling this option may incur a significant performance overhead. > >> > >> config XEN_X86_PVH > >> - bool "Support for running as a PVH guest (EXPERIMENTAL)" > >> - depends on X86_64 && XEN && EXPERIMENTAL > >> + bool "Support for running as a PVH guest" > >> + depends on X86_64 && XEN > >> default n > >> help > >> This option enables support for running as a PVH guest (PV guest > >> using hardware extensions) under a suitably capable hypervisor. > >> - This option is EXPERIMENTAL because the hypervisor interfaces > >> - which it uses is not yet considered stable therefore backwards and > >> - forwards compatibility is not yet guaranteed. If unsure, say N. > >> + If unsure, say N. > > > > Please do not change the text this way. > > The fact that CONFIG_EXPERIMENTAL is going away it doesn't change the > > fact that this feature is experimental. > > Maybe you want to replace EXPERIMENTAL with experimental, or if > > experimental has become as taboo word, I am sure you can find a suitable > > synonym. > > Ah, sorry, I misunderstood what was being recommended from the other > thread (quoting below...) > > On Sat, 23 Feb 2013, Konrad Rzeszutek Wilk wrote: > > It certainly is unstable right now (which is why it was unstaged from > > the v3.9 train). I hope that by v3.10 it won't be - at which > > point this patch (and the EXPERIMENTAL) makes sense. > > Only "depends on EXPERIMENTAL" must go away. Did you want either the > bool or help text to go away too? If neither, my original patch should > work. If you only want the bool text gone, I can send that version > instead. I think your original patch is good, but I'll let Konrad decide.