From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933205Ab3CTSqQ (ORCPT ); Wed, 20 Mar 2013 14:46:16 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:64131 "EHLO mail-pb0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932773Ab3CTSqP (ORCPT ); Wed, 20 Mar 2013 14:46:15 -0400 Date: Wed, 20 Mar 2013 11:46:12 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Michal Hocko cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm, hugetlb: include hugepages in meminfo In-Reply-To: <20130320095306.GA21856@dhcp22.suse.cz> Message-ID: References: <20130320095306.GA21856@dhcp22.suse.cz> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Mar 2013, Michal Hocko wrote: > On Tue 19-03-13 17:18:12, David Rientjes wrote: > > Particularly in oom conditions, it's troublesome that hugetlb memory is > > not displayed. All other meminfo that is emitted will not add up to what > > is expected, and there is no artifact left in the kernel log to show that > > a potentially significant amount of memory is actually allocated as > > hugepages which are not available to be reclaimed. > > Yes, I like the idea. It's bitten me already in the past. > > The only objection I have is that you print only default_hstate. You > just need to wrap your for_each_node_state by for_each_hstate to do > that. With that applied, feel free to add my > Acked-by: Michal Hocko > I didn't do this because it isn't already exported in /proc/meminfo and since we've made an effort to reduce the amount of information emitted by the oom killer at oom kill time to avoid spamming the kernel log, I only print the default hstate.