From: Xiong Zhou <jencce.kernel@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Xiong Zhou <jencce.kernel@gmail.com>,
linux-next@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] sound/soc/codec : fix build failure in next-201303225
Date: Mon, 25 Mar 2013 20:34:27 +0800 (CST) [thread overview]
Message-ID: <alpine.DEB.2.02.1303252017020.20514@M2420> (raw)
In-Reply-To: <20130325120601.GN18316@opensource.wolfsonmicro.com>
On Mon, 25 Mar 2013, Mark Brown wrote:
> On Mon, Mar 25, 2013 at 07:59:43PM +0800, Xiong Zhou wrote:
>
> > -const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE] = {
> > - "SYNCCLK rate", "8kHz", "16kHz", "ASYNCCLK rate",
> > -};
> > +extern const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE];
> > EXPORT_SYMBOL_GPL(arizona_rate_text);
>
> No, this isn't a good fix at all - we're moving the array to the header
> but still exporting it from this file which is not clever at all. The
> user should be conditional.
>
Yes, I agree with you much. Do you have some plan with this array?
The exproting seems not necesary right now, How about just moving
the array to the header?
next prev parent reply other threads:[~2013-03-25 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 11:59 Xiong Zhou
2013-03-25 12:06 ` Mark Brown
2013-03-25 12:34 ` Xiong Zhou [this message]
2013-03-25 12:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1303252017020.20514@M2420 \
--to=jencce.kernel@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®