From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Russell King <linux@arm.linux.org.uk>,
"tixy@linaro.org" <tixy@linaro.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
"nicolas.pitre@linaro.org" <nicolas.pitre@linaro.org>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] ARM: add the "bool" type definition to asm/mach/arch.h
Date: Tue, 30 Apr 2013 15:05:04 +0100 [thread overview]
Message-ID: <alpine.DEB.2.02.1304301504530.5398@kaball.uk.xensource.com> (raw)
In-Reply-To: <1367325487-8366-1-git-send-email-nicolas.ferre@atmel.com>
On Tue, 30 Apr 2013, Nicolas Ferre wrote:
> Addition of boolean field to machine_desc structure in commit
> 4dbfa9a25367cfa91aec0e56d75a6905d3242cd3 (ARM: Enable selection of
> SMP operations at boot time) was triggering compilation errors like:
>
> CC arch/arm/mach-at91/at91sam9260_devices.o
> In file included from arch/arm/mach-at91/at91sam9260_devices.c:12:0:
> arch/arm/include/asm/mach/arch.h:46:2: error: expected specifier-qualifier-list before "bool"
>
> So, we add the definition of "bool" by including the linux/types.h
> file to asm/mach/arch.h and make it self-contained.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> arch/arm/include/asm/mach/arch.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h
> index af8c54c..75bf079 100644
> --- a/arch/arm/include/asm/mach/arch.h
> +++ b/arch/arm/include/asm/mach/arch.h
> @@ -8,6 +8,8 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/types.h>
> +
> #ifndef __ASSEMBLY__
>
> struct tag;
> --
> 1.8.0
>
prev parent reply other threads:[~2013-04-30 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 9:33 linux-next build error (at91) - use of bool in mach/arch.h Nicolas Ferre
2013-04-30 9:39 ` Geert Uytterhoeven
2013-04-30 11:58 ` Stefano Stabellini
2013-04-30 12:40 ` Nicolas Ferre
2013-04-30 15:15 ` Nicolas Pitre
2013-04-30 15:59 ` Stefano Stabellini
2013-04-30 12:38 ` [PATCH] ARM: add the "bool" type definition to asm/mach/arch.h Nicolas Ferre
2013-04-30 14:05 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1304301504530.5398@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ludovic.desroches@atmel.com \
--cc=marc.zyngier@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=nicolas.pitre@linaro.org \
--cc=plagnioj@jcrosoft.com \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®