From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758709Ab3EAW0l (ORCPT ); Wed, 1 May 2013 18:26:41 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:54894 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756218Ab3EAW0j (ORCPT ); Wed, 1 May 2013 18:26:39 -0400 Date: Wed, 1 May 2013 15:26:37 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Cody P Schafer cc: Andrew Morton , Linux MM , LKML Subject: Re: [PATCH 1/4] mmzone: make holding lock_memory_hotplug() a requirement for updating pgdat size In-Reply-To: <1367446635-12856-2-git-send-email-cody@linux.vnet.ibm.com> Message-ID: References: <1367446635-12856-1-git-send-email-cody@linux.vnet.ibm.com> <1367446635-12856-2-git-send-email-cody@linux.vnet.ibm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 May 2013, Cody P Schafer wrote: > All updaters of pgdat size (spanned_pages, start_pfn, and > present_pages) currently also hold lock_memory_hotplug() (in addition > to pgdat_resize_lock()). > > Document this and make holding of that lock a requirement on the update > side for now, but keep the pgdat_resize_lock() around for readers that > can't lock a mutex. > > Signed-off-by: Cody P Schafer Nack, these fields are initialized at boot without lock_memory_hotplug(), so you're statement is wrong, and all you need is pgdat_resize_lock().