From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755932Ab3EaMCc (ORCPT ); Fri, 31 May 2013 08:02:32 -0400 Received: from smtp.citrix.com ([66.165.176.89]:28751 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113Ab3EaMCY (ORCPT ); Fri, 31 May 2013 08:02:24 -0400 X-IronPort-AV: E=Sophos;i="4.87,778,1363132800"; d="scan'208";a="28497450" Date: Fri, 31 May 2013 13:02:04 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Catalin Marinas CC: Stefano Stabellini , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xensource.com" , Will Deacon , "Ian.Campbell@citrix.com" , "konrad.wilk@oracle.com" Subject: Re: [PATCH RFC 1/6] [HACK!] arm64/xen: create links to arch/arm include files and Xen code In-Reply-To: <20130531103617.GA18045@localhost.cambridge.arm.com> Message-ID: References: <1369930713-6063-1-git-send-email-stefano.stabellini@eu.citrix.com> <20130531103617.GA18045@localhost.cambridge.arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 May 2013, Catalin Marinas wrote: > On Thu, May 30, 2013 at 05:18:28PM +0100, Stefano Stabellini wrote: > > Most of Xen support for ARM is common between ARMv7 and ARMv8. > > Create links to the code under arch/arm (bleah). > > > > Other, probably better alternatives: > > > > - move the code to a different location, maybe the header files to > > include/xen/arm and the code to drivers/xen/arm (still pretty ugly)? > > > > - create a copy of the code to arch/arm64 (even worse); > > KVM handles this in the Makefile by referencing back to arch/arm or even > the generic kvm directory. I think that's the 'cleanest' ;) Do you mean creating links in the Makefile or generating header file copies from the Makefile? Or do you mean using something like "-I arch/arm/include/asm/xen" in the arch/arm64 Makefile? I tried to find exactly what KVM is doing but I couldn't find the code you are talking about..