From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xensource.com>,
<will.deacon@arm.com>, <catalin.marinas@arm.com>,
<konrad.wilk@oracle.com>
Subject: Re: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64
Date: Wed, 5 Jun 2013 13:38:26 +0100 [thread overview]
Message-ID: <alpine.DEB.2.02.1306051334580.4589@kaball.uk.xensource.com> (raw)
In-Reply-To: <1370435014.24512.190.camel@zakaz.uk.xensource.com>
On Wed, 5 Jun 2013, Ian Campbell wrote:
> On Wed, 2013-06-05 at 13:15 +0100, Stefano Stabellini wrote:
> > Introduce CONFIG_XEN and the implementation of hypercall.S (that is
> > the only ARMv8 specific code in Xen support for ARM).
> >
> > Compile enlighten.c and grant_table.c from arch/arm.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> > [....]
> > +#define HYPERCALL_SIMPLE(hypercall) \
> > +ENTRY(HYPERVISOR_##hypercall) \
> > + mov x16, #__HYPERVISOR_##hypercall; \
> > + hvc XEN_IMM; \
> > + ret; \
>
> Not sure if this is corruption due to whitespace/email etc but it'd be
> nice to align those \'s.
They are aligned with ts=4, misaligned with ts=8 (ts is vim terminology
for "how many spaces a tab equals to") :-/
Given that according to Linux coding style tabs are 8 characters, I'll
fix the indentation.
next prev parent reply other threads:[~2013-06-05 12:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 12:14 [PATCH v3 0/6] Introduce Xen support to ARM64 Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 1/6] arm/xen: define xen_remap as ioremap_cached Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 2/6] arm64/xen: introduce asm/xen header files on arm64 Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 3/6] arm64/xen: implement ioremap_cached " Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 4/6] arm64/xen: use XEN_IO_PROTO_ABI_ARM on ARM64 Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S " Stefano Stabellini
2013-06-05 12:23 ` Ian Campbell
2013-06-05 12:38 ` Stefano Stabellini [this message]
2013-06-05 12:44 ` Arnd Bergmann
2013-06-05 12:50 ` Will Deacon
2013-06-05 14:43 ` Christopher Covington
2013-06-05 13:04 ` Stefano Stabellini
2013-06-06 14:42 ` Catalin Marinas
2013-06-06 16:19 ` Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 6/6] MAINTAINERS: add myself as arm64/xen maintainer Stefano Stabellini
2013-06-05 12:23 ` Ian Campbell
2013-06-05 14:27 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1306051334580.4589@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=catalin.marinas@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®