From: Thomas Gleixner <tglx@linutronix.de>
To: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
Cc: prarit@redhat.com, john.stultz@linaro.org,
hiroyuki.yokoyama.vx@renesas.com, takashi.yoshii.zj@renesas.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: hrtimer: one more expiry time overflow check in hrtimer_interrupt
Date: Fri, 28 Jun 2013 14:22:16 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1306281416080.4013@ionos.tec.linutronix.de> (raw)
In-Reply-To: <51B6D4C4.9080400@renesas.com>
On Tue, 11 Jun 2013, Shinya Kuribayashi wrote:
> When executing a date command to set the system date and time to a few
> seconds before the 2038 problem expiration time, we got a WARN_ON_ONCE()
> like this:
>
> root@renesas:~# date -s "2038-1-19 3:14:00"
> Tue Jan 19 03:14:00 GMT 2038
> (then wait for 7-8 seconds)
> root@renesas:~# [ 27.662658] ------------[ cut here ]------------
> [ 27.667297] WARNING: at kernel/time/clockevents.c:209 clockevents_program_event+0x3c/0x138()
> I found a similar issue fixed in v3.9 by Prarit Bhargava in commit
> 8f294b5a13 (hrtimer: Add expiry time overflow check in hrtimer_interrupt,
> 2013-04-08). It tried to resolve a overflow issue detected around 1970
> + 100 seconds.
>
> On the other hand, we have another call site of tick_program_event() at
> the bottom of hrtimer_interrupt(). The warning this time is triggered
> there, so we need to apply the same fix to it.
Well, the problem is that you are just papering over the underlying
issue of 32bit systems not being prepared for the year 2038 issue.
Just blindly silencing the warning is not going to make the system
survive 2038 in any sane way. All timespec/val related time functions
dealing with the clock realtime domain are simply broken in 2038 on
32bit, so it does not matter whether a warning triggers or not.
We really need to tackle the underlying problem and not bandaiding a
known to be broken system.
Thanks,
tglx
next prev parent reply other threads:[~2013-06-28 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 7:41 Shinya Kuribayashi
2013-06-12 12:21 ` Prarit Bhargava
2013-06-14 6:18 ` Shinya Kuribayashi
2013-06-28 12:22 ` Thomas Gleixner [this message]
2013-07-05 11:50 ` Shinya Kuribayashi
2013-07-05 13:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1306281416080.4013@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=hiroyuki.yokoyama.vx@renesas.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=shinya.kuribayashi.px@renesas.com \
--cc=takashi.yoshii.zj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®