From: Thomas Gleixner <tglx@linutronix.de>
To: Wang YanQing <udknight@gmail.com>
Cc: Chuansheng Liu <chuansheng.liu@intel.com>,
mingo@kernel.org, peterz@infradead.org, jbeulich@suse.com,
paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org,
mina86@mina86.org, srivatsa.bhat@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, jun.zhang@intel.com,
fengguang.wu@intel.com
Subject: Re: [PATCH V2] smp: Give WARN()ing when calling smp_call_function_many()/single() in serving irq
Date: Sun, 7 Jul 2013 15:47:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1307071546540.32106@ionos.tec.linutronix.de> (raw)
In-Reply-To: <20130707035907.GA2875@udknight>
On Sun, 7 Jul 2013, Wang YanQing wrote:
> On Fri, Jul 05, 2013 at 04:37:14PM +0200, Thomas Gleixner wrote:
> > Hmm, even there it matters, because of the following scenario:
> >
> > CPU 0
> > smp_call_function_single(CPU 1)
> > csd_lock(CPU 1)
>
> No, smpl_call_function_single(CPU 1)
> will csd_lock(CPU 0), not csd_lock(CPU 1)
>
> > irq_enter()
> > irq_exit()
> > __do_softirq()
> > smp_call_function_many()
> > setup csd (CPU 1)
> > csd_lock(CPU 1) ==> CPU 0 deadlocked itself.
> >
>
> maybe below is the scenario:
> irq_enter()
> irq_exit()
> __do_softirq()
> smp_call_function_single()
> setup csd (CPU 1)
> csd_lock(CPU 0) ==> CPU 0 deadlocked itself.
Right, I fatfingered that :)
next prev parent reply other threads:[~2013-07-07 13:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 15:18 [PATCH] smp: give WARN in case of in_interrupt() when calling smp_call_function_many/single Chuansheng Liu
2013-02-06 13:42 ` [tip:core/locking] smp: Give WARN()ing if in_interrupt() when calling smp_call_function_many()/single() tip-bot for Chuansheng Liu
2013-02-11 12:20 ` [tip:core/locking] Revert "smp: Give WARN()ing if in_interrupt() when calling smp_call_function_many()/single()" tip-bot for Ingo Molnar
2013-02-16 5:26 ` Liu, Chuansheng
2013-02-16 13:57 ` [PATCH] smp: Give WARN()ing when calling smp_call_function_many()/single() in serving irq Chuansheng Liu
2013-02-16 14:10 ` [PATCH V2] " Chuansheng Liu
2013-02-18 1:38 ` Fengguang Wu
2013-02-19 23:01 ` Andrew Morton
2013-02-20 1:06 ` Fengguang Wu
2013-02-20 1:22 ` Liu, Chuansheng
2013-02-27 14:50 ` Lai Jiangshan
2013-03-01 3:37 ` Liu, Chuansheng
2013-08-05 22:46 ` Andrew Morton
2013-07-05 13:50 ` Thomas Gleixner
2013-07-05 14:37 ` Thomas Gleixner
2013-07-07 3:59 ` Wang YanQing
2013-07-07 13:47 ` Thomas Gleixner [this message]
2013-12-06 1:29 ` Max Filippov
2013-12-06 14:02 ` Thomas Gleixner
2013-12-06 18:31 ` Max Filippov
2013-07-07 2:41 ` Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1307071546540.32106@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=fengguang.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=jun.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mina86@mina86.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®