From: Julia Lawall <julia.lawall@lip6.fr>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"backports@vger.kernel.org" <backports@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Julia Lawall <julia.lawall@lip6.fr>,
USB list <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiri Slaby <jslaby@suse.cz>, Jiri Kosina <jkosina@suse.cz>,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH] backports: backport drvdata = NULL core driver fixes
Date: Fri, 19 Jul 2013 23:27:09 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1307192326080.2229@localhost6.localdomain6> (raw)
In-Reply-To: <CAB=NE6VHgure2+2VA=XWtaii4Wc_rG7YZ=_ZetgGnvouh7HJPw@mail.gmail.com>
On Fri, 19 Jul 2013, Luis R. Rodriguez wrote:
> On Fri, Jul 19, 2013 at 2:07 PM, Luis R. Rodriguez
> <mcgrof@do-not-panic.com> wrote:
> >> This is not a very good idea. Although setting drvdata to NULL allowed
> >> a lot of code to be removed, it also exposed a bunch of hidden bugs --
> >> drivers were using the drvdata value even after their remove function
> >> returned.
> >
> > Eek, have we not SmPL'ify'd a proof yet to ensure code like this no
> > longer exists? Julia? :)
>
> Come to think of it, perhaps we should require *proof* with SmPL like
> this in future to avoid regressions ?
Is it a concurrency problem? SmPL is not so good at that in the general
case. One would have to know a specific case where other functions of the
driver can be invoked after remove.
julia
next prev parent reply other threads:[~2013-07-19 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 23:48 Luis R. Rodriguez
2013-07-19 14:17 ` Alan Stern
2013-07-19 21:07 ` Luis R. Rodriguez
2013-07-19 21:08 ` Luis R. Rodriguez
2013-07-19 21:27 ` Julia Lawall [this message]
2013-07-19 21:41 ` Luis R. Rodriguez
2013-07-20 3:36 ` Alan Stern
2013-07-23 22:43 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1307192326080.2229@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=backports@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=nbd@openwrt.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®