From: Julia Lawall <julia.lawall@lip6.fr>
To: Shalin Mehta <shalinmehta85@gmail.com>
Cc: gregkh@linuxfoundation.org, klmckinney1@gmail.com,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration
Date: Tue, 17 Sep 2013 10:35:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1309171035000.2252@hadrien> (raw)
In-Reply-To: <1379401962-10208-1-git-send-email-shalinmehta85@gmail.com>
On Tue, 17 Sep 2013, Shalin Mehta wrote:
> From: Shalin Mehta <shalinmehta85@gmail.com>
>
> NOTE: Sending it again. I got mail delivery failure due to typo in emai ID gregkh@linuxfoundation.org
I think that such a comment should go below the ---, since it doesn't have
to be preserved in git.
julia
>
>
> The function implementations of the PHSModule didn't match with the declaration. The functions are static
> in the declaration but in the implemntation they are non-static
>
> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
> ---
> drivers/staging/bcm/PHSModule.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c
> index af5d22f..56c5bee 100644
> --- a/drivers/staging/bcm/PHSModule.c
> +++ b/drivers/staging/bcm/PHSModule.c
> @@ -596,7 +596,7 @@ ULONG PhsDeleteSFRules(IN void *pvContext, IN B_UINT16 uiVcid)
> * 0 if successful,
> * >0 Error.
> */
> -ULONG PhsCompress(IN void *pvContext,
> +static ULONG PhsCompress(IN void *pvContext,
> IN B_UINT16 uiVcid,
> IN B_UINT16 uiClsId,
> IN void *pvInputBuffer,
> @@ -677,7 +677,7 @@ ULONG PhsCompress(IN void *pvContext,
> * 0 if successful,
> * >0 Error.
> */
> -ULONG PhsDeCompress(IN void *pvContext,
> +static ULONG PhsDeCompress(IN void *pvContext,
> IN B_UINT16 uiVcid,
> IN void *pvInputBuffer,
> OUT void *pvOutputBuffer,
> @@ -829,7 +829,7 @@ UINT GetServiceFlowEntry(IN struct bcm_phs_table *psServiceFlowTable,
> return PHS_INVALID_TABLE_INDEX;
> }
>
> -UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
> +static UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
> IN B_UINT32 uiClsid, enum bcm_phs_classifier_context eClsContext,
> OUT struct bcm_phs_classifier_entry **ppstClassifierEntry)
> {
> @@ -880,7 +880,7 @@ static UINT GetPhsRuleEntry(IN struct bcm_phs_classifier_table *pstClassifierTab
> return PHS_INVALID_TABLE_INDEX;
> }
>
> -UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
> +static UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
> IN struct bcm_phs_table *psServiceFlowTable,
> struct bcm_phs_rule *psPhsRule,
> B_UINT8 u8AssociatedPHSI)
> @@ -913,7 +913,7 @@ UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
> return uiStatus;
> }
>
> -UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
> +static UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
> IN B_UINT16 uiClsId,
> IN struct bcm_phs_entry *pstServiceFlowEntry,
> struct bcm_phs_rule *psPhsRule,
> @@ -1239,7 +1239,7 @@ void DumpPhsRules(struct bcm_phs_extension *pDeviceExtension)
> * header.
> * 0 -If PHS rule is NULL.If PHSI is 0 indicateing packet as uncompressed.
> */
> -int phs_decompress(unsigned char *in_buf,
> +static int phs_decompress(unsigned char *in_buf,
> unsigned char *out_buf,
> struct bcm_phs_rule *decomp_phs_rules,
> UINT *header_size)
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-09-17 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 7:12 Shalin Mehta
2013-09-17 7:58 ` Dan Carpenter
2013-09-17 8:35 ` Julia Lawall [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-17 7:42 Shalin Mehta
2013-09-17 7:04 Shalin Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1309171035000.2252@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=klmckinney1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shalinmehta85@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®