mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Martin Walch <walch.martin@web.de>
Cc: "Michal Marek" <mmarek@suse.cz>,
	"Jiri Kosina" <trivial@kernel.org>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Benjamin Poirier" <bpoirier@suse.de>,
	"Dirk Gouders" <dirk@gouders.net>,
	"Wang YanQing" <udknight@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Jean Delvare" <jdelvare@suse.de>,
	"Kees Cook" <keescook@chromium.org>,
	"Alan Cox" <alan@linux.intel.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] kconfig: adjust warning message for conflicting types
Date: Tue, 1 Oct 2013 22:33:48 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1310012230090.5682@chino.kir.corp.google.com> (raw)
In-Reply-To: <2865108.QhoiiS6j3s@tacticalops>

On Wed, 2 Oct 2013, Martin Walch wrote:

> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index b970101..e511df5 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -119,7 +119,7 @@ void menu_set_type(int type)
>  		sym->type = type;
>  		return;
>  	}
> -	menu_warn(current_entry, "type of '%s' redefined from '%s' to '%s'",
> +	menu_warn(current_entry, "type of '%s' not redefined from '%s' to '%s'",
>  	    sym->name ? sym->name : "<choice>",
>  	    sym_type_name(sym->type), sym_type_name(type));
>  }

The warning is stating that the symbol was attempted to be redefined from 
one type to another, not that it was successful, so I don't think this 
patch actually helps make anything clearer.  (gcc warns when a symbol is 
redefined by saying "redefintion of `blah`".)  Perhaps include that the 
redefinition was ignored?

      reply	other threads:[~2013-10-02  5:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02  5:24 Martin Walch
2013-10-02  5:33 ` David Rientjes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1310012230090.5682@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@linux.intel.com \
    --cc=arve@android.com \
    --cc=bpoirier@suse.de \
    --cc=dirk@gouders.net \
    --cc=jdelvare@suse.de \
    --cc=keescook@chromium.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=trivial@kernel.org \
    --cc=udknight@gmail.com \
    --cc=walch.martin@web.de \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®