From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robherring2@gmail.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH] of: set dma_mask to point to coherent_dma_mask
Date: Tue, 12 Nov 2013 13:21:44 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1311121315460.26077@kaball.uk.xensource.com> (raw)
In-Reply-To: <20131112101955.GF16735@n2100.arm.linux.org.uk>
On Tue, 12 Nov 2013, Russell King - ARM Linux wrote:
> On Mon, Nov 11, 2013 at 04:59:14PM +0000, Stefano Stabellini wrote:
> > On Wed, 6 Nov 2013, Stefano Stabellini wrote:
> > > On Sat, 2 Nov 2013, Grant Likely wrote:
> > > > On Wed, 30 Oct 2013 00:05:22 -0500, Rob Herring <robherring2@gmail.com> wrote:
> > > > > From: Rob Herring <rob.herring@calxeda.com>
> > > > >
> > > > > Platform devices created by DT code don't initialize dma_mask pointer to
> > > > > anything. Set it to coherent_dma_mask by default if the architecture
> > > > > code has not set it.
> > > > >
> > > > > Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> > > >
> > > > I believe this is okay. I haven't done any testing to back up that
> > > > opinion though.
> > >
> > > Tested-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >
> > BTW I hope you are planning on sending this upstream soon, because
> > without it I can very easily corrupt my root fs by simply booting the system.
>
> What's the mechanism for that corruption? Having the DMA mask not set
> should not cause DMA corruption - that hints at something else being
> wrong, and that needs to be investigated.
Russell, you are right.
I went through the swiotlb-xen code and I realized that I missed a
map_page call on one of the (usually unused) fallback paths.
Thanks!!
prev parent reply other threads:[~2013-11-12 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 5:05 Rob Herring
2013-11-02 18:07 ` Grant Likely
2013-11-06 16:46 ` Stefano Stabellini
2013-11-11 16:59 ` Stefano Stabellini
2013-11-12 7:01 ` Grant Likely
2013-11-12 10:19 ` Russell King - ARM Linux
2013-11-12 13:21 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1311121315460.26077@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®