mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
	bigeasy@linutronix.de, rostedt@goodmis.org, tj@kernel.org,
	mingo@redhat.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
	john.stultz@linaro.org, paulmck@linux.vnet.ibm.com
Subject: Re: [RFC] Timer: Migrate running timers
Date: Wed, 20 Nov 2013 12:42:47 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.02.1311201148272.30673@ionos.tec.linutronix.de> (raw)
In-Reply-To: <3a0ef8e5a838fcf1a3cdaecc029cc97dea5edf65.1384940804.git.viresh.kumar@linaro.org>

Viresh,

On Wed, 20 Nov 2013, Viresh Kumar wrote:

> Migration of timers from idle cores to non-idle ones for power saving is very
> well working and really saves a lot of power for us. What's currently not
> working is the migration of running timers Or timers which re-arms themselves.
>
> There are complications with migrating timers which schedules themselves again
> from their handler. del_timer_sync() can't detect that the timer's handler
> yet has not finished.

Because you try to violate the semantics of the existing code. There
is a reason why we enforce that running timers must be requeued on the
base they are running on.

Now you try to duct tape it into submission. That's not going to fly.

The timer wheel code is not designed to allow that and it has lots of
other short comings and historic burdens. I'm not going to accept more
duct tape and fragile hackery into that code.

I'm already working on a complete replacement infrastructure, which
avoids all the short comings of the current timer implementation
including this one. 

It's going to be a massive effort to convert everything over to the
new infrastructure so we can kill the timer wheel, but that's less
scary and less risky than trying to add more fragility to the existing
code.

Thanks,

	tglx



	    

  reply	other threads:[~2013-11-20 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20  9:49 Viresh Kumar
2013-11-20 11:42 ` Thomas Gleixner [this message]
2013-11-20 14:27   ` viresh kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1311201148272.30673@ionos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=john.stultz@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=patches@linaro.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®