From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755106Ab3LROXM (ORCPT ); Wed, 18 Dec 2013 09:23:12 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:44236 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754733Ab3LROXJ (ORCPT ); Wed, 18 Dec 2013 09:23:09 -0500 X-IronPort-AV: E=Sophos;i="4.95,508,1384300800"; d="scan'208";a="83498952" Date: Wed, 18 Dec 2013 14:22:35 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Konrad Rzeszutek Wilk CC: , , , , , Subject: Re: [Xen-devel] [PATCH v11 02/12] xen/pvh: Define what an PVH guest is. In-Reply-To: <1387313503-31362-3-git-send-email-konrad.wilk@oracle.com> Message-ID: References: <1387313503-31362-1-git-send-email-konrad.wilk@oracle.com> <1387313503-31362-3-git-send-email-konrad.wilk@oracle.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: > From: Mukesh Rathor > > Which is a PV guest with auto page translation enabled > and with vector callback. It is a cross between PVHVM and PV. > > The Xen side defines PVH as (from docs/misc/pvh-readme.txt, > with modifications): > > "* the guest uses auto translate: > - p2m is managed by Xen > - pagetables are owned by the guest > - mmu_update hypercall not available > * it uses event callback and not vlapic emulation, > * IDT is native, so set_trap_table hcall is also N/A for a PVH guest. > > For a full list of hcalls supported for PVH, see pvh_hypercall64_table > in arch/x86/hvm/hvm.c in xen. From the ABI prespective, it's mostly a > PV guest with auto translate, although it does use hvm_op for setting > callback vector." > > We don't have yet a Kconfig entry setup as we do not > have all the parts ready for it - so we piggyback > on the PVHVM config option. This scaffolding will > be removed later. > > Signed-off-by: Mukesh Rathor > Signed-off-by: Konrad Rzeszutek Wilk Could you please add an "&& CONFIG_X86"? > include/xen/xen.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/xen/xen.h b/include/xen/xen.h > index a74d436..1d6a237 100644 > --- a/include/xen/xen.h > +++ b/include/xen/xen.h > @@ -29,4 +29,13 @@ extern enum xen_domain_type xen_domain_type; > #define xen_initial_domain() (0) > #endif /* CONFIG_XEN_DOM0 */ > > +#ifdef CONFIG_XEN_PVHVM > +/* Temporarily under XEN_PVHVM, but will be under CONFIG_XEN_PVH */ > +#include > +#define xen_pvh_domain() (xen_pv_domain() && \ > + xen_feature(XENFEAT_auto_translated_physmap) && \ > + xen_have_vector_callback) > +#else > +#define xen_pvh_domain() (0) > +#endif > #endif /* _XEN_XEN_H */ > -- > 1.8.3.1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >