From: Julia Lawall <julia.lawall@lip6.fr>
To: Alessandro Zummo <a.zummo@towertech.it>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
grant.likely@linaro.org, robh+dt@kernel.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: question about drivers/rtc/rtc-cmos.c
Date: Fri, 27 Dec 2013 21:26:14 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1312272124180.2018@localhost6.localdomain6> (raw)
In-Reply-To: <20131227182942.66e7b109@linux.lan.towertech.it>
On Fri, 27 Dec 2013, Alessandro Zummo wrote:
> On Wed, 25 Dec 2013 20:32:12 +0100 (CET)
> Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> > Is it intentional that the error code returned by
> > hpet_register_irq_handler is put ina local variable that will not be seen
> > at label cleanup1? The return value is retval, which is 0 at this point.
>
> Well, I'd say it's an error. Did you got it by hand
> or with one of your tools? ;)
Coccinelle. No idea if it an happen in real life.
I will drop err and replace it by retval.
julia
next prev parent reply other threads:[~2013-12-27 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 19:32 Julia Lawall
2013-12-27 17:29 ` Alessandro Zummo
2013-12-27 20:26 ` Julia Lawall [this message]
2013-12-27 22:22 ` Andrew Morton
2013-12-27 22:32 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1312272124180.2018@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=a.zummo@towertech.it \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®