From: David Rientjes <rientjes@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
mingo@kernel.org, peterz@infradead.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
linux-kernel@vger.kernel.org, Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH] cpusets: Allocate heap only when required
Date: Fri, 24 Jan 2014 02:51:12 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1401240243260.24372@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140124103631.GB4101@htj.dyndns.org>
On Fri, 24 Jan 2014, Tejun Heo wrote:
> > It's not harmless, if heap_init() fails with -ENOMEM then the write fails
> > even though it may not be for memory_spread_page or memory_spread_slab,
> > which is the minority of the callers of this function.
>
> And depending on details like that would actually be more harmful.
> Please remember that all writes through cgroupfs may fail under very
> high memory pressure. There's no "this specific set of writes to this
> specific knob isn't affected by memory pressure" guarantee.
>
Nobody is depending on shit, the patch is removing a completely pointless
memory allocation in braindead cpuset code. What you think is "harmful"
or "more harmful" is irrelevant, but nobody said anything about depending
on that behavior to do anything.
Thanks.
next prev parent reply other threads:[~2014-01-24 10:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 11:15 Viresh Kumar
2014-01-23 21:31 ` David Rientjes
2014-01-24 1:58 ` Li Zefan
2014-01-24 4:57 ` Viresh Kumar
2014-01-24 10:27 ` Tejun Heo
2014-01-24 10:33 ` Viresh Kumar
2014-01-24 10:40 ` Tejun Heo
2014-01-24 10:33 ` David Rientjes
2014-01-24 10:36 ` Tejun Heo
2014-01-24 10:51 ` David Rientjes [this message]
2014-01-24 10:59 ` Tejun Heo
2014-01-24 11:15 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1401240243260.24372@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cgroups@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=patches@linaro.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®