From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752652AbaAZElt (ORCPT ); Sat, 25 Jan 2014 23:41:49 -0500 Received: from mail-bk0-f47.google.com ([209.85.214.47]:63549 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbaAZEls (ORCPT ); Sat, 25 Jan 2014 23:41:48 -0500 Date: Sat, 25 Jan 2014 20:41:41 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Dave Hansen cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, peterz@infradead.org, penberg@kernel.org, linux@arm.linux.org.uk Subject: Re: [linux-next][PATCH] mm: slub: work around unneeded lockdep warning In-Reply-To: <20140124152023.A450E599@viggo.jf.intel.com> Message-ID: References: <20140124152023.A450E599@viggo.jf.intel.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jan 2014, Dave Hansen wrote: > From: Dave Hansen > > The slub code does some setup during early boot in > early_kmem_cache_node_alloc() with some local data. There is no > possible way that another CPU can see this data, so the slub code > doesn't unnecessarily lock it. However, some new lockdep asserts > check to make sure that add_partial() _always_ has the list_lock > held. > > Just add the locking, even though it is technically unnecessary. > > Signed-off-by: Dave Hansen > Cc: Peter Zijlstra > Cc: Pekka Enberg > Cc: Russell King Acked-by: David Rientjes