From: David Rientjes <rientjes@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov@parallels.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] slub: Do not assert not having lock in removing freed partial
Date: Wed, 5 Feb 2014 17:26:35 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1402051725270.20281@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140205200632.021dc613@gandalf.local.home>
On Wed, 5 Feb 2014, Steven Rostedt wrote:
> > We'll want to do something similiar for the add_partial() called from
> > early_kmem_cache_node_alloc(), right? It had the added n->list_lock for
> > the same reason and is done during early init where nobody else can be
> > referencing a kmem_cache_node.
> >
> > It would probably be better to define these in terms of "partial slabs
> > that cannot have anyone else accessing it" rather than "freed slabs".
>
> Perhaps then we just use the __remove_partial() and __add_partial()
> that does not do the checks. That's common practice to use a "__" to
> denote that it's special and usually doesn't require locking.
>
Sounds appropriate. Andrew released a mmotm today so I'm assuming it will
be in linux-next tomorrow with my {add,remove}_full() patch but it
shouldn't matter if you're going to be playing with
{add,remove}_partial().
prev parent reply other threads:[~2014-02-06 1:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 0:24 Steven Rostedt
2014-02-06 0:46 ` David Rientjes
2014-02-06 1:06 ` Steven Rostedt
2014-02-06 1:26 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1402051725270.20281@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®