From: David Rientjes <rientjes@google.com>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: tglx@linutronix.de, fengguang.wu@intel.com, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] time/cpuidle:Fixup fallout from hrtimer broadcast mode inclusion
Date: Sat, 8 Feb 2014 23:31:01 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1402082329410.8686@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140207172924.8248.55002.stgit@preeti>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1973 bytes --]
On Fri, 7 Feb 2014, Preeti U Murthy wrote:
> The broadcast timer registration has to be done only when
> GENERIC_CLOCKEVENTS_BROADCAST and TICK_ONESHOT config options are enabled.
> Also fix max_delta_ticks value for the pseudo clock device.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> ---
>
> kernel/time/tick-broadcast-hrtimer.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/time/tick-broadcast-hrtimer.c b/kernel/time/tick-broadcast-hrtimer.c
> index 5591aaa..bc383ac 100644
> --- a/kernel/time/tick-broadcast-hrtimer.c
> +++ b/kernel/time/tick-broadcast-hrtimer.c
> @@ -81,7 +81,7 @@ static struct clock_event_device ce_broadcast_hrtimer = {
> .min_delta_ns = 1,
> .max_delta_ns = KTIME_MAX,
> .min_delta_ticks = 1,
> - .max_delta_ticks = KTIME_MAX,
> + .max_delta_ticks = ULONG_MAX,
> .mult = 1,
> .shift = 0,
> .cpumask = cpu_all_mask,
> @@ -102,9 +102,11 @@ static enum hrtimer_restart bc_handler(struct hrtimer *t)
> return HRTIMER_RESTART;
> }
>
> +#if defined(CONFIG_GENERIC_CLOCKEVENTS_BROADCAST) && defined(CONFIG_TICK_ONESHOT)
> void tick_setup_hrtimer_broadcast(void)
> {
> hrtimer_init(&bctimer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
> bctimer.function = bc_handler;
> clockevents_register_device(&ce_broadcast_hrtimer);
> }
> +#endif
I see a build error in timers/core today:
kernel/time/tick-broadcast-hrtimer.c:101:6: error: redefinition of 'tick_setup_hrtimer_broadcast'
include/linux/clockchips.h:194:20: note: previous definition of 'tick_setup_hrtimer_broadcast' was here
and I assume this is the intended fix for that, although it isn't
mentioned in the changelog.
After it's applied, this is left over:
kernel/time/tick-broadcast-hrtimer.c:91:29: warning: ‘bc_handler’ defined but not used [-Wunused-function]
next prev parent reply other threads:[~2014-02-09 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 17:29 Preeti U Murthy
2014-02-07 17:57 ` Thomas Gleixner
2014-02-09 6:02 ` Preeti U Murthy
2014-02-09 14:16 ` [tip:timers/core] tick: Fixup more fallout from hrtimer broadcast mode tip-bot for Preeti U Murthy
2014-02-09 7:31 ` David Rientjes [this message]
2014-02-09 10:04 ` [PATCH] time/cpuidle:Fixup fallout from hrtimer broadcast mode inclusion Preeti U Murthy
2014-02-09 21:35 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1402082329410.8686@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®