From: David Rientjes <rientjes@google.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH] x86: fix two sparse warnings in early boot string handling
Date: Tue, 11 Feb 2014 14:26:45 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1402111425430.32020@chino.kir.corp.google.com> (raw)
In-Reply-To: <1392143619-11453-1-git-send-email-paul.gortmaker@windriver.com>
On Tue, 11 Feb 2014, Paul Gortmaker wrote:
> Fixes:
>
> arch/x86/boot/compressed/../string.c:60:14: warning: symbol 'atou' was not declared. Should it be static?
> arch/x86/boot/string.c:133:6: warning: symbol 'strstr' was not declared. Should it be static?
>
> The atou one could be considered a false positive; it seems somehow
> caused by including ./string.c from within /compressed/string.c file.
> However git grep shows only the atou prototype and declaration, so
> it is completely unused and we can hence delete it.
>
Declaring a prototype in a header file would be pointless if there is no
current breakage; I don't see why you can't remove strstr() in
arch/x86/boot/string.c entirely. What breaks?
next prev parent reply other threads:[~2014-02-11 22:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 18:33 Paul Gortmaker
2014-02-11 22:26 ` David Rientjes [this message]
2014-02-12 2:00 ` Paul Gortmaker
2014-02-12 2:23 ` David Rientjes
2014-02-12 14:57 ` Paul Gortmaker
2014-02-12 15:49 ` Paul Gortmaker
2014-02-12 22:00 ` David Rientjes
2014-02-12 22:29 ` Paul Gortmaker
2014-02-12 23:14 ` David Rientjes
2014-02-12 23:31 ` H. Peter Anvin
2014-02-13 10:31 ` Matt Fleming
2014-02-13 14:01 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1402111425430.32020@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®