From: Thomas Gleixner <tglx@linutronix.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jingoo Han <jg1.han@samsung.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Mohit Kumar <mohit.kumar@st.com>, pci <linux-pci@vger.kernel.org>
Subject: Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
Date: Tue, 25 Feb 2014 00:15:42 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1402250014320.21251@ionos.tec.linutronix.de> (raw)
In-Reply-To: <CAErSpo4doDT7TC5ACxnizWJFTq+8N1Q3Y8F9_oosTg6w0GQfCA@mail.gmail.com>
On Mon, 24 Feb 2014, Bjorn Helgaas wrote:
> On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Mon, 24 Feb 2014, Bjorn Helgaas wrote:
> >> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> >> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
> >> >>
> >> >> There is no reason to care about irq_desc in that context, escpecially
> >> >> as irq_data for that interrupt is retrieved as well.
> >> >>
> >> >> Use the proper accessor for the msi descriptor
> >> >>
> >> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >> >> Cc: Bjorn Helgaas <bhelgaas@google.com>
> >> >> Cc: Jingoo Han <jg1.han@samsung.com>
> >> >> Cc: Mohit Kumar <mohit.kumar@st.com>
> >> >> Cc: pci <linux-pci@vger.kernel.org>
> >> >
> >> > Acked-by: Jingoo Han <jg1.han@samsung.com>
> >>
> >> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> >>
> >> Thomas, I assume you'll merge this along with the rest of your series.
> >> I don't have any pending changes in this area.
> >
> > I can do, but it does not depend on anything else, so you can pick it
> > up as well. Either way is fine.
>
> I never know what to do with these. I suggested that you pick it up
> so the whole series would be together, because I assumed it would make
> more sense in the git history to have all these similar changes
> grouped together. But maybe that really doesn't matter.
>
> What's the recommended practice?
Dunno. There is no rule. I'll merge it up with the rest of the lot.
Thanks,
tglx
next prev parent reply other threads:[~2014-02-24 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 23:33 Jingoo Han
2014-02-24 21:38 ` Bjorn Helgaas
2014-02-24 22:06 ` Thomas Gleixner
2014-02-24 23:03 ` Bjorn Helgaas
2014-02-24 23:15 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-23 21:40 [patch 00/26] genirq: Another round of tree wide cleanups Thomas Gleixner
2014-02-23 21:40 ` [patch 07/26] pci: pcie-designware: Remove irq_desc abuse Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1402250014320.21251@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mohit.kumar@st.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®