From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755443AbaCDS4R (ORCPT ); Tue, 4 Mar 2014 13:56:17 -0500 Received: from www.linutronix.de ([62.245.132.108]:35936 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbaCDS4Q (ORCPT ); Tue, 4 Mar 2014 13:56:16 -0500 Date: Tue, 4 Mar 2014 19:56:22 +0100 (CET) From: Thomas Gleixner To: Alexander Shiyan cc: linux-kernel@vger.kernel.org, Mark Brown , Arnd Bergmann Subject: Re: [PATCH] irq: Export symbol no_action() In-Reply-To: <1393955639.661016045@f378.i.mail.ru> Message-ID: References: <1393656316-26757-1-git-send-email-shc_work@mail.ru> <1393931733.877810306@f371.i.mail.ru> <1393955639.661016045@f378.i.mail.ru> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1935601741-1393959383=:18573" X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1935601741-1393959383=:18573 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: 8BIT On Tue, 4 Mar 2014, Alexander Shiyan wrote: > +сс Arnd Bergmann > > Вторник, 4 марта 2014, 16:46 +01:00 от Thomas Gleixner : > > On Tue, 4 Mar 2014, Alexander Shiyan wrote: > > > > > Вторник, 4 марта 2014, 12:05 +01:00 от Thomas Gleixner : > > > > On Sat, 1 Mar 2014, Alexander Shiyan wrote: > > > > > > > > > This will allow to use dummy IRQ handler no_action() from > > > > > drivers compiled as module. For example, dummy handler is could > > > > > be used for drivers that use ARM FIQ interrupts. > > > > > > > > And why exactly requires a driver which uses ARM FIQ interrupts the > > > > no_action implementation? > > > > > > > > FIQ Interrupt handler is not used in this function. In FIQ case this > > > is just a dummy declaration. Real handler is assigned by using the > > > set_fiq_handler(). > > > > Why do you need a dummy declaration at all? > > > > set_fiq_handler() is completely detached from the generic interrupt > > subsystem. > > Some limitations of hardware, such as bit interleaving for normal and > FIQ interrupts for mask/status registers, led to the implement single > driver for interrupt handling. > As a result, all interrupts can be described equally, and single mechanism > is used for the request/free and enable/disable. > Correct me if I'm wrong. Driver that implements it, resent several times > and expect comments within 3 months [1], you are the only one person, > Thomas, specified as maintainer for this subsystem. > I repeat, if I'm wrong in the implementation, let's fix this. > > [1]: http://marc.info/?l=linux-arm-kernel&m=139132855024699 Lemme find this and review it. Thanks, tglx --8323329-1935601741-1393959383=:18573--