From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Stefani Seibold <stefani@seibold.net>,
Greg KH <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, Andi Kleen <ak@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
John Stultz <john.stultz@linaro.org>,
Pavel Emelyanov <xemul@parallels.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
andriy.shevchenko@linux.intel.com,
Martin Runge <Martin.Runge@rohde-schwarz.com>,
Andreas Brief <Andreas.Brief@rohde-schwarz.com>
Subject: Re: [PATCH] x86, vdso32: fix out of memory handling setup vDSO
Date: Thu, 20 Mar 2014 16:15:59 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1403201614360.18573@ionos.tec.linutronix.de> (raw)
In-Reply-To: <CALCETrVgC7yKsu0KM0=TfUuX9msn9ru_nG=Fv6Mz6PKDTnWGnQ@mail.gmail.com>
On Thu, 20 Mar 2014, Andy Lutomirski wrote:
> On Thu, Mar 20, 2014 at 5:30 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Thu, 20 Mar 2014, Stefani Seibold wrote:
> >> All complains are design decisions not made by me. I will send a patch
> >> for the GFP_ATOMIC thing. For the other one it would be the best to ask
> >> Andy for the reason.
> >
> > I'm not saying it's your fault, but if we rework code, then we really
> > should question such things. What happens if you remove the x32 call
> > and make the x64 subsys thing valid for both cases?
> >
>
> It's not just that. The x86_64 and x32 vdso page arrays are *far*
> cleaner than the 32-bit variant. They manage to do the entire vdso
> setup dance without any allocation at all. This avoids silly
> questions about error handling and GFP_KERNEL :)
>
> See vdso/vdso.S for the rather small amount of magic needed.
Is there any reason why we can't use that for x86_32 ?
Thanks,
tglx
next prev parent reply other threads:[~2014-03-20 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 7:45 Stefani Seibold
2014-03-20 9:53 ` Thomas Gleixner
2014-03-20 10:49 ` Thomas Gleixner
2014-03-20 11:38 ` Stefani Seibold
2014-03-20 12:30 ` Thomas Gleixner
2014-03-20 15:02 ` Andy Lutomirski
2014-03-20 15:15 ` Thomas Gleixner [this message]
2014-03-20 15:18 ` Andy Lutomirski
2014-03-20 15:59 ` H. Peter Anvin
2014-03-20 16:56 ` Andy Lutomirski
2014-03-20 17:06 ` H. Peter Anvin
2014-03-20 22:01 ` [PATCH] x86: Load the 32-bit vdso in place, just like the 64-bit vdsos Andy Lutomirski
2014-03-20 22:30 ` [tip:x86/vdso] " tip-bot for Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1403201614360.18573@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=Andreas.Brief@rohde-schwarz.com \
--cc=Martin.Runge@rohde-schwarz.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gorcunov@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=stefani@seibold.net \
--cc=x86@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®