From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbaCYLU2 (ORCPT ); Tue, 25 Mar 2014 07:20:28 -0400 Received: from smtp.citrix.com ([66.165.176.89]:49565 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbaCYLU0 (ORCPT ); Tue, 25 Mar 2014 07:20:26 -0400 X-IronPort-AV: E=Sophos;i="4.97,728,1389744000"; d="scan'208";a="114613991" Date: Tue, 25 Mar 2014 11:19:55 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: CC: Stefano Stabellini , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "konrad.wilk@oracle.com" , Will Deacon , Ian Campbell , "linux@arm.linux.org.uk" , "olof@lixom.net" , "arnd@arndb.de" , "nico@linaro.org" , "cov@codeaurora.org" , Subject: Re: [PATCH v9 4/5] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops In-Reply-To: <20140217175552.GB8361@arm.com> Message-ID: References: <1389292336-9292-4-git-send-email-stefano.stabellini@eu.citrix.com> <20140217175552.GB8361@arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Feb 2014, Catalin Marinas wrote: > On Mon, Feb 17, 2014 at 12:25:42PM +0000, Stefano Stabellini wrote: > > On Thu, 9 Jan 2014, Stefano Stabellini wrote: > > > Introduce CONFIG_PARAVIRT and PARAVIRT_TIME_ACCOUNTING on ARM64. > > > Necessary duplication of paravirt.h and paravirt.c with ARM. > > > > > > The only paravirt interface supported is pv_time_ops.steal_clock, so no > > > runtime pvops patching needed. > > > > > > This allows us to make use of steal_account_process_tick for stolen > > > ticks accounting. > > > > > > Signed-off-by: Stefano Stabellini > > > CC: will.deacon@arm.com > > > CC: nico@linaro.org > > > CC: marc.zyngier@arm.com > > > CC: cov@codeaurora.org > > > CC: arnd@arndb.de > > > CC: olof@lixom.net > > > CC: Catalin.Marinas@arm.com > > > > Catalin, Will, are you happy with this patch for 3.15? > > It's pretty small and looks fine to me. However, I would like someone > with more virtualisation experience than me to ack it (e.g. Marc Z). Ping? Marc, could you please give it a review? > Some nitpicks: > > > > +config PARAVIRT > > > + bool "Enable paravirtualization code" > > > + ---help--- > > > + This changes the kernel so it can modify itself when it is run > > > + under a hypervisor, potentially improving performance significantly > > > + over full virtualization. > > > + > > > +config PARAVIRT_TIME_ACCOUNTING > > > + bool "Paravirtual steal time accounting" > > > + select PARAVIRT > > > + default n > > > + ---help--- > > For consistency with this file, just use "help" rather than > "---help---". > > > > --- /dev/null > > > +++ b/arch/arm64/include/asm/paravirt.h > > > @@ -0,0 +1,20 @@ > > > +#ifndef _ASM_ARM64_PARAVIRT_H > > > +#define _ASM_ARM64_PARAVIRT_H > > __ASM_PARAVIRT_H for consistency. > > -- > Catalin >