From: Thomas Gleixner <tglx@linutronix.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Xiubo Li <Li.Xiubo@freescale.com>,
shawn.guo@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock
Date: Tue, 15 Apr 2014 23:53:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1404152352560.22697@ionos.tec.linutronix.de> (raw)
In-Reply-To: <534D27AB.7070109@linaro.org>
On Tue, 15 Apr 2014, Daniel Lezcano wrote:
> On 04/15/2014 12:48 PM, Xiubo Li wrote:
> > The pit_read_sched_clock mean to getting the current counter value,
> > and the vf pit timer is a down count timer, this should return
> > the counter value or the cycles elapsed.
> >
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > ---
> > drivers/clocksource/vf_pit_timer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clocksource/vf_pit_timer.c
> > b/drivers/clocksource/vf_pit_timer.c
> > index 02821b0..a918bc4 100644
> > --- a/drivers/clocksource/vf_pit_timer.c
> > +++ b/drivers/clocksource/vf_pit_timer.c
> > @@ -54,7 +54,7 @@ static inline void pit_irq_acknowledge(void)
> >
> > static u64 pit_read_sched_clock(void)
> > {
> > - return __raw_readl(clksrc_base + PITCVAL);
> > + return ~__raw_readl(clksrc_base + PITCVAL);
> > }
> >
> > static int __init pit_clocksource_init(unsigned long rate)
> >
>
> Hi Xiubo,
>
> thanks for the patch but this has already been fixed [1] and is available in
> the timers/urgent branch.
It's in Linus tree already and tagged for stable.
Thanks,
tglx
next prev parent reply other threads:[~2014-04-15 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 10:48 Xiubo Li
2014-04-15 12:35 ` Daniel Lezcano
2014-04-15 21:53 ` Thomas Gleixner [this message]
2014-04-16 0:51 ` Li.Xiubo
2014-04-16 0:33 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1404152352560.22697@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=Li.Xiubo@freescale.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®