From: Thomas Gleixner <tglx@linutronix.de>
To: Darren Hart <dvhart@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Darren Hart <darren@dvhart.com>,
Davidlohr Bueso <davidlohr@hp.com>,
Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Clark Williams <williams@redhat.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Roland McGrath <roland@hack.frob.com>,
Carlos ODonell <carlos@redhat.com>,
Jakub Jelinek <jakub@redhat.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [patch 0/3] futex/rtmutex: Fix issues exposed by trinity
Date: Tue, 13 May 2014 11:08:47 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1405131100510.6261@ionos.tec.linutronix.de> (raw)
In-Reply-To: <20140513035404.GA68181@dvhart-mac01.local>
On Mon, 12 May 2014, Darren Hart wrote:
> On Mon, May 12, 2014 at 08:45:32PM -0000, Thomas Gleixner wrote:
> > strace tells me:
> >
> > futex(0x600e00, FUTEX_LOCK_PI_PRIVATE, 1) = -1 EINVAL (Invalid argument)
> >
> > but the return value of pthread_mutex_lock() is 0
>
> So something is clearly wrong there - however, were you looking at the comments
> (sorry, I mean the C code), or the implementation (all the ASM)? The only way
> I've been able to be sure in the past is to delete the ASM files and recompile
> using the C files. Hopefully we'll be able to drop all the ASM in the pthread
> calls soonish (measured in years in glibc development time scales).... sigh.
The C implementation does:
if (INTERNAL_SYSCALL_ERROR_P (e, __err)
&& (INTERNAL_SYSCALL_ERRNO (e, __err) == ESRCH
|| INTERNAL_SYSCALL_ERRNO (e, __err) == EDEADLK))
{
assert (INTERNAL_SYSCALL_ERRNO (e, __err) != EDEADLK
|| (kind != PTHREAD_MUTEX_ERRORCHECK_NP
&& kind != PTHREAD_MUTEX_RECURSIVE_NP));
/* ESRCH can happen only for non-robust PI mutexes where
the owner of the lock died. */
assert (INTERNAL_SYSCALL_ERRNO (e, __err) != ESRCH || !robust);
/* Delay the thread indefinitely. */
while (1)
pause_not_cancel ();
}
So anything else than ESRCH and EDEADLK is ignored and then the thing
happily returns 0 at the end. Unlock is the same:
{
int robust = mutex->__data.__kind & PTHREAD_MUTEX_ROBUST_NORMAL_NP;
int private = (robust
? PTHREAD_ROBUST_MUTEX_PSHARED (mutex)
: PTHREAD_MUTEX_PSHARED (mutex));
INTERNAL_SYSCALL_DECL (__err);
INTERNAL_SYSCALL (futex, __err, 2, &mutex->__data.__lock,
__lll_private_flag (FUTEX_UNLOCK_PI, private));
}
Quality stuff that.
Thanks,
tglx
next prev parent reply other threads:[~2014-05-13 9:08 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 20:45 Thomas Gleixner
2014-05-12 20:45 ` [patch 1/3] rtmutex: Add missing deadlock check Thomas Gleixner
2014-05-13 5:51 ` Lai Jiangshan
2014-05-13 8:45 ` Thomas Gleixner
2014-05-13 8:48 ` Peter Zijlstra
2014-05-13 16:12 ` Paul E. McKenney
2014-05-13 19:42 ` Thomas Gleixner
2014-05-13 20:20 ` Steven Rostedt
2014-05-13 20:36 ` Paul E. McKenney
2014-05-13 21:27 ` Thomas Gleixner
2014-05-13 22:00 ` Paul E. McKenney
2014-05-13 22:44 ` Steven Rostedt
2014-05-13 23:27 ` Paul E. McKenney
2014-05-13 23:53 ` Steven Rostedt
2014-05-14 0:12 ` Paul E. McKenney
2014-05-14 6:54 ` Thomas Gleixner
[not found] ` <CAGChsmO9GO1Z2VBbw7uLtTXpYowdoUQbK8C3=Dt2jtGAnc6D2A@mail.gmail.com>
2014-05-14 13:33 ` Thomas Gleixner
2014-05-14 6:42 ` Thomas Gleixner
2014-05-14 12:59 ` Thomas Gleixner
2014-05-12 20:45 ` [patch 2/3] futex: Add another early deadlock detection check Thomas Gleixner
2014-05-19 12:22 ` [tip:core/urgent] " tip-bot for Thomas Gleixner
2014-05-12 20:45 ` [patch 3/3] futex: Prevent attaching to kernel threads Thomas Gleixner
2014-05-12 20:54 ` Peter Zijlstra
2014-05-12 21:16 ` Thomas Gleixner
2014-05-12 21:59 ` Davidlohr Bueso
2014-05-12 22:18 ` Thomas Gleixner
2014-05-19 12:22 ` [tip:core/urgent] " tip-bot for Thomas Gleixner
2014-05-12 21:37 ` [patch 0/3] futex/rtmutex: Fix issues exposed by trinity Steven Rostedt
2014-05-12 21:52 ` Thomas Gleixner
2014-05-12 22:08 ` Steven Rostedt
2014-05-12 22:37 ` Thomas Gleixner
2014-05-12 23:18 ` Steven Rostedt
2014-05-13 6:37 ` Ingo Molnar
2014-05-13 3:54 ` Darren Hart
2014-05-13 9:08 ` Thomas Gleixner [this message]
2014-05-14 7:06 ` Carlos O'Donell
2014-05-14 10:26 ` Thomas Gleixner
2014-05-14 20:59 ` Carlos O'Donell
2014-05-14 22:54 ` Thomas Gleixner
2014-05-15 7:37 ` Peter Zijlstra
2014-05-15 8:25 ` Peter Zijlstra
2014-05-16 18:21 ` Carlos O'Donell
2014-05-14 6:58 ` Carlos O'Donell
2014-05-14 9:22 ` Peter Zijlstra
2014-05-14 21:17 ` Carlos O'Donell
2014-05-14 23:11 ` Thomas Gleixner
2014-05-16 17:54 ` Carlos O'Donell
2014-05-15 8:07 ` Peter Zijlstra
2014-05-16 18:14 ` Carlos O'Donell
2014-05-14 9:53 ` Thomas Gleixner
2014-05-14 10:07 ` Peter Zijlstra
2014-05-14 10:28 ` Thomas Gleixner
2014-05-16 17:55 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1405131100510.6261@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=carlos@redhat.com \
--cc=darren@dvhart.com \
--cc=davej@redhat.com \
--cc=davidlohr@hp.com \
--cc=dvhart@linux.intel.com \
--cc=jakub@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=roland@hack.frob.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®