From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751167AbaEWUzQ (ORCPT ); Fri, 23 May 2014 16:55:16 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:56178 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbaEWUzO (ORCPT ); Fri, 23 May 2014 16:55:14 -0400 Date: Fri, 23 May 2014 13:55:11 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: David Herrmann cc: linux-kernel@vger.kernel.org, Andrew Morton , Wanpeng Li , Naoya Horiguchi , Vladimir Cernov , Johannes Weiner , Hugh Dickins , linux-mm@kvack.org Subject: Re: [PATCH] mm/madvise: fix WILLNEED on SHM/ANON to actually do something In-Reply-To: <1400847135-22291-1-git-send-email-dh.herrmann@gmail.com> Message-ID: References: <1400847135-22291-1-git-send-email-dh.herrmann@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 May 2014, David Herrmann wrote: > diff --git a/mm/madvise.c b/mm/madvise.c > index 539eeb9..a402f8f 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -195,7 +195,7 @@ static void force_shm_swapin_readahead(struct vm_area_struct *vma, > for (; start < end; start += PAGE_SIZE) { > index = ((start - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff; > > - page = find_get_page(mapping, index); > + page = find_get_entry(mapping, index); > if (!radix_tree_exceptional_entry(page)) { > if (page) > page_cache_release(page); This is already in -mm from Johannes, see http://marc.info/?l=linux-kernel&m=139998616712729. Check out http://www.ozlabs.org/~akpm/mmotm/ for this kernel.