From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932470AbaFCSOY (ORCPT ); Tue, 3 Jun 2014 14:14:24 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:39374 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbaFCSOW (ORCPT ); Tue, 3 Jun 2014 14:14:22 -0400 X-IronPort-AV: E=Sophos;i="4.98,967,1392159600"; d="scan'208";a="77879928" Date: Tue, 3 Jun 2014 20:14:19 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Stephen Boyd cc: Julia Lawall , Michal Marek , linux-kernel@vger.kernel.org, Mitchel Humpherys , Gilles Muller , Nicolas Palix , Grant Likely , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables In-Reply-To: <538E09C1.30200@codeaurora.org> Message-ID: References: <1401213858-31950-1-git-send-email-sboyd@codeaurora.org> <538E09C1.30200@codeaurora.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Jun 2014, Stephen Boyd wrote: > On 06/03/14 03:15, Julia Lawall wrote: > > Failure to terminate an of_device_id table can lead to confusing > > failures depending on where the compiler places the array. Add a > > check to make sure these tables are terminated. Thanks to Mitchel > > Humpherys for coming up with the pattern initially. > > > > Cc: Mitchel Humpherys > > Cc: Julia Lawall > > Cc: Gilles Muller > > Cc: Nicolas Palix > > Cc: Grant Likely > > Cc: Rob Herring > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Stephen Boyd > > Acked-by: Grant Likely > > Signed-off-by: Julia Lawall > > > > --- > > > > v3: Removed unneeded rule bad_of_table. Placed * in context rule on the > > closing brace; putting it on the field caused all fields to be marked. > > > > > These seem like only minor changes. Why was my authorship removed? Probably because I don't know how to provide a new vesion of the patch properly. What should I have done? There were quite a lot of modifications. It seemed easier to just send a complete new version. julia