From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932195AbaFIV5W (ORCPT ); Mon, 9 Jun 2014 17:57:22 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:39021 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753838AbaFIV5S (ORCPT ); Mon, 9 Jun 2014 17:57:18 -0400 Date: Mon, 9 Jun 2014 14:57:16 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Luiz Capitulino cc: akpm@linux-foundation.org, andi@firstfloor.org, riel@redhat.com, yinghai@kernel.org, isimatu.yasuaki@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] x86: numa: drop ZONE_ALIGN In-Reply-To: <20140609144355.63a91968@redhat.com> Message-ID: References: <20140608181436.17de69ac@redhat.com> <20140609144355.63a91968@redhat.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Jun 2014, Luiz Capitulino wrote: > > > diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h > > > index 4064aca..01b493e 100644 > > > --- a/arch/x86/include/asm/numa.h > > > +++ b/arch/x86/include/asm/numa.h > > > @@ -9,7 +9,6 @@ > > > #ifdef CONFIG_NUMA > > > > > > #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) > > > -#define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) > > > > > > /* > > > * Too small node sizes may confuse the VM badly. Usually they > > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > > > index 1d045f9..69f6362 100644 > > > --- a/arch/x86/mm/numa.c > > > +++ b/arch/x86/mm/numa.c > > > @@ -200,8 +200,6 @@ static void __init setup_node_data(int nid, u64 start, u64 end) > > > if (end && (end - start) < NODE_MIN_SIZE) > > > return; > > > > > > - start = roundup(start, ZONE_ALIGN); > > > - > > > printk(KERN_INFO "Initmem setup node %d [mem %#010Lx-%#010Lx]\n", > > > nid, start, end - 1); > > > > > > > What ensures this start address is page aligned from the BIOS? > > To which start address do you refer to? The start address displayed in the dmesg is not page aligned anymore with your change, correct? acpi_parse_memory_affinity() does no transformations on the table, the base address is coming strictly from the SRAT and there is no page alignment requirement in the ACPI specification. NODE_DATA(nid)->node_start_pfn will be correct because it does the shift for you, but it still seems you want to at least align to PAGE_SIZE here.