From: Julia Lawall <julia.lawall@lip6.fr>
To: Joe Perches <joe@perches.com>
Cc: Fabian Frederick <fabf@skynet.be>,
linux-kernel@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>
Subject: Re: [PATCH 1/1] scripts/coccinelle/free: add conditional kfree test
Date: Tue, 17 Jun 2014 23:33:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1406172331001.2055@localhost6.localdomain6> (raw)
In-Reply-To: <1403035539.2722.3.camel@joe-AO725>
On Tue, 17 Jun 2014, Joe Perches wrote:
> On Tue, 2014-06-17 at 21:43 +0200, Fabian Frederick wrote:
> > This patch adds a trivial script warning on
> >
> > if(foo)
> > kfree(foo)
> >
> > (based on checkpatch)
> []
> > diff --git a/scripts/coccinelle/free/cond_kfree.cocci b/scripts/coccinelle/free/cond_kfree.cocci
> []
> > +* if (E)
> > +* kfree@p(E);
>
> You should probably add all of the unnecessary
> conditional tests that checkpatch uses:
>
> kfree
> usb_free_urb
> debugfs_remove
> debugfs_remove_recursive
Personally, I would prefer that the message encourage the user to consider
whether it is necessary to call these functions with NULL as an argument
in any case.
julia
next prev parent reply other threads:[~2014-06-17 21:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 19:43 Fabian Frederick
2014-06-17 20:05 ` Joe Perches
2014-06-17 20:45 ` SF Markus Elfring
2014-06-17 21:33 ` Julia Lawall [this message]
2014-06-17 21:58 ` Joe Perches
2014-06-18 5:25 ` Julia Lawall
2014-06-18 5:45 ` Joe Perches
2014-06-18 9:02 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1406172331001.2055@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=fabf@skynet.be \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®