mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	Ian Kent <raven@themaw.net>,
	Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
	Thorsten Diehl <thorsten.diehl@de.ibm.com>,
	Andrea Righi <andrea@betterlinux.com>,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Stefan Bader <stefan.bader@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] /proc/stat vs. failed order-4 allocation
Date: Tue, 24 Jun 2014 16:52:22 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1406241650340.22030@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140623160414.f64bcfbfc3f40b4844552427@linux-foundation.org>

On Mon, 23 Jun 2014, Andrew Morton wrote:

> On Sat, 21 Jun 2014 11:10:58 +0200 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> 
> > On Wed, Jun 18, 2014 at 02:29:31PM -0700, Andrew Morton wrote:
> > > On Mon, 16 Jun 2014 11:04:50 +0200 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> > > 
> > > > These two patches are supposed to "fix" failed order-4 memory
> > > > allocations which have been observed when reading /proc/stat.
> > > > The problem has been observed on s390 as well as on x86.
> > > > 
> > > > To address the problem change the seq_file memory allocations to
> > > > fallback to use vmalloc, so that allocations also work if memory
> > > > is fragmented.
> > > > 
> > > > This approach seems to be simpler and less intrusive than changing
> > > > /proc/stat to use an interator. Also it "fixes" other users as well,
> > > > which use seq_file's single_open() interface.
> > > 
> > > Yes, those changes look pretty simple and effective.
> > > 
> > > I'm unclear on how urgent these fixes are.  I semi-randomly tagged them
> > > for 3.16 with a -stable backport, but that could be changed?
> > 
> > I assume tagged for 3.16 means you intend to get it merged before 3.16
> > gets released?
> > If so, then that would be fine with me.
> 
> um, actually, no, sorry, I meant merge for 3.17-rc1 with a -stable backport.
> 
> We can do 3.16 of course, but for what reasons?
> 

Heiko's patches should also fix 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1319244 as reported 
by Stefan Bader.  I've pinged them to determine if there is any other 
issues with -mm.

  reply	other threads:[~2014-06-24 23:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16  9:04 Heiko Carstens
2014-06-16  9:04 ` [PATCH 1/2] proc/stat: convert to single_open_size() Heiko Carstens
2014-06-18 23:28   ` David Rientjes
2014-06-16  9:04 ` [PATCH 2/2] fs/seq_file: fallback to vmalloc allocation Heiko Carstens
2014-06-18 23:31   ` David Rientjes
2014-06-18 21:29 ` [PATCH 0/2] /proc/stat vs. failed order-4 allocation Andrew Morton
2014-06-21  9:10   ` Heiko Carstens
2014-06-23 23:04     ` Andrew Morton
2014-06-24 23:52       ` David Rientjes [this message]
2014-06-25  6:15         ` Heiko Carstens
2014-06-26  2:20           ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1406241650340.22030@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrea@betterlinux.com \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=hch@infradead.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raven@themaw.net \
    --cc=stefan.bader@canonical.com \
    --cc=thorsten.diehl@de.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®