From: David Rientjes <rientjes@google.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: monstr@monstr.eu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] microblaze: fixes includes in sigcontext.h
Date: Thu, 3 Jul 2014 14:57:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1407031456430.10658@chino.kir.corp.google.com> (raw)
In-Reply-To: <1404423935-5287-1-git-send-email-xerofoify@gmail.com>
On Thu, 3 Jul 2014, Nicholas Krause wrote:
> diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h
> index 55873c8..1180d9b 100644
> --- a/arch/microblaze/include/uapi/asm/sigcontext.h
> +++ b/arch/microblaze/include/uapi/asm/sigcontext.h
> @@ -9,8 +9,7 @@
> #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H
> #define _ASM_MICROBLAZE_SIGCONTEXT_H
>
> -/* FIXME should be linux/ptrace.h */
> -#include <asm/ptrace.h>
> +#include <linux/ptrace.h>
>
> struct sigcontext {
> struct pt_regs regs;
Umm, does this even compile? How does sigcontext.h get the definition of
struct pt_regs? Seems like it would be better to just do a forward
declaration.
next prev parent reply other threads:[~2014-07-03 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 21:45 Nicholas Krause
2014-07-03 21:57 ` David Rientjes [this message]
2014-07-03 22:08 ` Nick Krause
2014-07-03 22:14 ` David Rientjes
2014-07-03 22:15 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1407031456430.10658@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®