mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Greg KH <greg@kroah.com>
Cc: Himangi Saraogi <himangi774@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Correct the size argument to devm_kzalloc
Date: Mon, 7 Jul 2014 06:32:04 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1407070629100.2014@localhost6.localdomain6> (raw)
In-Reply-To: <20140706235818.GA18457@kroah.com>



On Sun, 6 Jul 2014, Greg KH wrote:

> On Sun, Jul 06, 2014 at 09:43:42PM +0530, Himangi Saraogi wrote:
> > nhi->rx_rings does not have type as struct tb_ring *, as it is a
> > double pointer so the elements of the array should have pointer type,
> > not structure type.
> > 
> > The Coccinelle semantic patch that makes this change is as follows:
> > 
> > // <smpl>
> > @disable sizeof_type_expr@
> > type T;
> > T **x;
> > @@
> > 
> >   x =
> >   <+...sizeof(
> > - T
> > + *x
> >   )...+>
> > // </smpl>
> > 
> > Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> > ---
> >  drivers/thunderbolt/nhi.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Any reason you didn't cc: the developers in charge of this code so they
> see it and can pick it up?  Otherwise it's just going to float around on
> the mailing list, listless and sad.

They don't seem to be in the MAINTAINERS file.

Himangi, you would see some people if you drop the --nogit-fallback 
argument from get_maintainers.  Maybe that is too strict.

julia

  reply	other threads:[~2014-07-07  4:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-06 16:13 Himangi Saraogi
2014-07-06 16:31 ` Joe Perches
2014-07-06 23:58 ` Greg KH
2014-07-07  4:32   ` Julia Lawall [this message]
2014-07-07  5:42     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1407070629100.2014@localhost6.localdomain6 \
    --to=julia.lawall@lip6.fr \
    --cc=greg@kroah.com \
    --cc=himangi774@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®