From: David Rientjes <rientjes@google.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spin_lock_*(): Always evaluate second argument
Date: Mon, 21 Jul 2014 17:47:25 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1407211747090.7042@chino.kir.corp.google.com> (raw)
In-Reply-To: <539ED993.80807@acm.org>
On Mon, 16 Jun 2014, Bart Van Assche wrote:
> Evaluating a macro argument only if certain configuration options
> have been selected is confusing and error-prone. Hence always
> evaluate the second argument of spin_lock_nested() and
> spin_lock_nest_lock().
>
> This patch has the intentional side effect that it avoids that the
> following warning is reported for netif_addr_lock_nested() when
> building with CONFIG_DEBUG_LOCK_ALLOC=n and with W=1:
>
> include/linux/netdevice.h: In function 'netif_addr_lock_nested':
> include/linux/netdevice.h:2865:6: warning: variable 'subclass' set but not used [-Wunused-but-set-variable]
> int subclass = SINGLE_DEPTH_NESTING;
> ^
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: David S. Miller <davem@davemloft.net>
Bart, could you please resend this patch with my acked-by?
prev parent reply other threads:[~2014-07-22 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 11:48 Bart Van Assche
2014-06-17 1:20 ` David Rientjes
2014-07-22 0:47 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1407211747090.7042@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=bvanassche@acm.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®